From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: [patch] mode-line faces on 256-color terminals Date: Wed, 22 Dec 2004 15:08:50 -0800 Message-ID: <200412222308.iBMN8rBT002077@scanner2.ics.uci.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1103757080 13408 80.91.229.6 (22 Dec 2004 23:11:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Dec 2004 23:11:20 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 23 00:11:14 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ChFdS-0004Pu-00 for ; Thu, 23 Dec 2004 00:11:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ChFo1-0004gA-Sf for ged-emacs-devel@m.gmane.org; Wed, 22 Dec 2004 18:22:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ChFmv-0004Po-Eg for emacs-devel@gnu.org; Wed, 22 Dec 2004 18:21:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ChFms-0004Nl-0k for emacs-devel@gnu.org; Wed, 22 Dec 2004 18:20:58 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ChFmr-0004NS-Ni for emacs-devel@gnu.org; Wed, 22 Dec 2004 18:20:57 -0500 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ChFc8-0001LO-1S for emacs-devel@gnu.org; Wed, 22 Dec 2004 18:09:52 -0500 Original-Received: from vino.ics.uci.edu (dann@vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.12.10/8.12.10) with ESMTP id iBMN8rBT002077 for ; Wed, 22 Dec 2004 15:08:53 -0800 (PST) Original-To: emacs-devel@gnu.org Original-Lines: 60 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-96.09, required 5, J_CHICKENPOX_52, MSGID_FROM_MTA_SHORT, USER_IN_WHITELIST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31339 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31339 The mode-line* faces were somehow missed when converting the face definitions in faces.el to use min-colors, so that they work on terminals that support 88 (or 256) colors. This patch fixes the above issue. Is it OK? 2004-12-22 Dan Nicolaescu * faces.el (mode-line, mode-line-inactive): Use min-colors. Index: faces.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v retrieving revision 1.296 diff -c -3 -p -c -r1.296 faces.el *** faces.el 21 Dec 2004 11:37:25 -0000 1.296 --- faces.el 22 Dec 2004 23:02:48 -0000 *************** created." *** 1783,1789 **** (defface mode-line ! '((((type x w32 mac) (class color)) :box (:line-width -1 :style released-button) :background "grey75" :foreground "black") (t --- 1783,1789 ---- (defface mode-line ! '((((class color) (min-colors 88)) :box (:line-width -1 :style released-button) :background "grey75" :foreground "black") (t *************** created." *** 1796,1806 **** (defface mode-line-inactive '((default :inherit mode-line) ! (((type x w32 mac) (background light) (class color)) :weight light :box (:line-width -1 :color "grey75" :style nil) :foreground "grey20" :background "grey90") ! (((type x w32 mac) (background dark) (class color)) :weight light :box (:line-width -1 :color "grey40" :style nil) :foreground "grey80" :background "grey30")) --- 1796,1806 ---- (defface mode-line-inactive '((default :inherit mode-line) ! (((class color) (min-colors 88) (background light)) :weight light :box (:line-width -1 :color "grey75" :style nil) :foreground "grey20" :background "grey90") ! (((class color) (min-colors 88) (background dark) ) :weight light :box (:line-width -1 :color "grey40" :style nil) :foreground "grey80" :background "grey30"))