From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Faces for Mode Line and Mode Line Inactive Date: Mon, 06 Dec 2004 10:47:37 -0800 Message-ID: <200412061847.iB6Ild3G024738@scanner2.ics.uci.edu> References: <006d01c4da5e$bd51eb60$0200a8c0@sedrcw11488> <01c4db0f$Blat.v2.2.2$1ee17160@zahav.net.il> <001101c4db1b$e34757c0$0200a8c0@sedrcw11488> <87sm6k2ve1.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1102358978 18659 80.91.229.6 (6 Dec 2004 18:49:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 6 Dec 2004 18:49:38 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 06 19:49:32 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CbNvQ-0000ag-00 for ; Mon, 06 Dec 2004 19:49:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CbO5B-0001QP-Ny for ged-emacs-devel@m.gmane.org; Mon, 06 Dec 2004 13:59:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CbO4v-0001Ov-OO for emacs-devel@gnu.org; Mon, 06 Dec 2004 13:59:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CbO4u-0001OA-5Q for emacs-devel@gnu.org; Mon, 06 Dec 2004 13:59:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CbO4t-0001O0-LY for emacs-devel@gnu.org; Mon, 06 Dec 2004 13:59:19 -0500 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CbNuZ-0003Uo-04; Mon, 06 Dec 2004 13:48:39 -0500 Original-Received: from vino.ics.uci.edu (dann@vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.12.10/8.12.10) with ESMTP id iB6Ild3G024738; Mon, 6 Dec 2004 10:47:39 -0800 (PST) Original-To: Stefan Monnier Original-Lines: 57 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-96.09, required 5, J_CHICKENPOX_52, MSGID_FROM_MTA_SHORT, USER_IN_WHITELIST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30760 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30760 Stefan Monnier writes: > The code I see in faces.el is appended. It says that the face > unconditionally inherits from mode-line. This is how it should be, AFAIK. [snip] Not completely related to this discussion, but related to faces.el: Shouldn't the mode-line and mode-line-inactive deffaces use min-colors? (I somehow missed them when converting the other standard deffaces to use min-colors). May I check in this patch? *** faces.el 06 Dec 2004 07:51:19 -0800 1.293 --- faces.el 06 Dec 2004 10:37:26 -0800 *************** *** 1775,1781 **** (defface mode-line ! '((((type x w32 mac) (class color)) :box (:line-width -1 :style released-button) :background "grey75" :foreground "black") (t --- 1775,1781 ---- (defface mode-line ! '((((class color) (min-colors 88)) :box (:line-width -1 :style released-button) :background "grey75" :foreground "black") (t *************** *** 1788,1798 **** (defface mode-line-inactive '((t :inherit mode-line) ! (((type x w32 mac) (background light) (class color)) :weight light :box (:line-width -1 :color "grey75" :style nil) :foreground "grey20" :background "grey90") ! (((type x w32 mac) (background dark) (class color)) :weight light :box (:line-width -1 :color "grey40" :style nil) :foreground "grey80" :background "grey30")) --- 1788,1798 ---- (defface mode-line-inactive '((t :inherit mode-line) ! (((background light) (class color) (min-colors 88)) :weight light :box (:line-width -1 :color "grey75" :style nil) :foreground "grey20" :background "grey90") ! (((background dark) (class color) (min-colors 88)) :weight light :box (:line-width -1 :color "grey40" :style nil) :foreground "grey80" :background "grey30"))