From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: defconst in life.el Date: Mon, 22 Nov 2004 20:34:56 -0600 (CST) Message-ID: <200411230234.iAN2Yur25830@raven.dms.auburn.edu> References: <200411141840.iAEIeXG24252@raven.dms.auburn.edu> <87k6so2ljb.fsf-monnier+emacs@gnu.org> <200411142139.iAELd9q27391@raven.dms.auburn.edu> <200411142251.iAEMpfG27635@raven.dms.auburn.edu> <200411170148.KAA24839@etlken.m17n.org> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1101177430 11860 80.91.229.6 (23 Nov 2004 02:37:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Nov 2004 02:37:10 +0000 (UTC) Cc: ttn@glug.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 23 03:36:56 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CWQY3-0002J9-00 for ; Tue, 23 Nov 2004 03:36:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CWQh8-0000Fu-JM for ged-emacs-devel@m.gmane.org; Mon, 22 Nov 2004 21:46:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CWQh0-0000Fp-BC for emacs-devel@gnu.org; Mon, 22 Nov 2004 21:46:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CWQgz-0000Fd-Sk for emacs-devel@gnu.org; Mon, 22 Nov 2004 21:46:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CWQgz-0000Fa-Oz for emacs-devel@gnu.org; Mon, 22 Nov 2004 21:46:09 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CWQXV-0000mp-7t for emacs-devel@gnu.org; Mon, 22 Nov 2004 21:36:21 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id iAN2a8Fu017613; Mon, 22 Nov 2004 20:36:08 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id iAN2Yur25830; Mon, 22 Nov 2004 20:34:56 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: handa@m17n.org In-reply-to: <200411170148.KAA24839@etlken.m17n.org> (message from Kenichi Handa on Wed, 17 Nov 2004 10:48:09 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30269 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30269 Does the following version of my patch look OK? If nobody ever would want to change `lao-key-alist', one could use something more along the lines of what Stefan suggested. However, the current defconst's are misleading and generate compiler warnings, so _some_ kind of change seems necessary. ===File ~/lao-latest-diff=================================== *** lao.el 01 Sep 2003 16:08:19 -0500 1.8 --- lao.el 22 Nov 2004 19:48:41 -0600 *************** *** 2,7 **** --- 2,8 ---- ;; Copyright (C) 1997 Electrotechnical Laboratory, JAPAN. ;; Licensed to the Free Software Foundation. + ;; Copyright (C) 2004 Free Software Foundation. ;; Keywords: multilingual, input method, Lao *************** *** 42,48 **** (compose-string (quail-lookup-map-and-concat quail-current-key)))) control-flag) ! (defconst lao-key-alist '(("!" . "1") ("\"" . "=") ("#" . "3") --- 43,51 ---- (compose-string (quail-lookup-map-and-concat quail-current-key)))) control-flag) ! ;; If you change the value of this variable while lao is already loaded, ! ;; you need to re-load it to properly re-initialize related alists. ! (defvar lao-key-alist '(("!" . "1") ("\"" . "=") ("#" . "3") *************** *** 148,159 **** ("\\9" . "໙") )) ! (defconst lao-consonant-key-alist nil) ! (defconst lao-semivowel-key-alist nil) ! (defconst lao-vowel-key-alist nil) ! (defconst lao-voweltone-key-alist nil) ! (defconst lao-tone-key-alist nil) ! (defconst lao-other-key-alist nil) (let ((tail lao-key-alist) elt phonetic-type) --- 151,170 ---- ("\\9" . "໙") )) ! (defvar lao-consonant-key-alist nil) ! (defvar lao-semivowel-key-alist nil) ! (defvar lao-vowel-key-alist nil) ! (defvar lao-voweltone-key-alist nil) ! (defvar lao-tone-key-alist nil) ! (defvar lao-other-key-alist nil) ! ! ;; These need to be re-initialized if lao is re-loaded. ! (setq lao-consonant-key-alist nil ! lao-semivowel-key-alist nil ! lao-vowel-key-alist nil ! lao-voweltone-key-alist nil ! lao-tone-key-alist nil ! lao-other-key-alist nil) (let ((tail lao-key-alist) elt phonetic-type) *************** *** 197,201 **** --- 208,214 ---- (v-state (lao-vowel-key-alist . t-state)) (t-state lao-tone-key-alist)))) + (provide 'lao) + ;;; arch-tag: 23863a30-a8bf-402c-b7ce-c517a7aa8570 ;;; lao.el ends here ============================================================ LocalWords: diff