From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: completing-read case problem Date: Sun, 21 Nov 2004 13:02:26 -0600 (CST) Message-ID: <200411211902.iALJ2QN21676@raven.dms.auburn.edu> References: <200411101929.iAAJThfq007309@haifa.math.ias.edu> <200411140703.iAE73Gd1019094@haifa.math.ias.edu> <200411151943.iAFJhYL6009036@haifa.math.ias.edu> <200411152307.iAFN7TB06089@raven.dms.auburn.edu> <200411160252.iAG2qiP0017791@haifa.math.ias.edu> <200411210518.iAL5IKJg018118@haifa.math.ias.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1101063860 12522 80.91.229.6 (21 Nov 2004 19:04:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 21 Nov 2004 19:04:20 +0000 (UTC) Cc: Simon Josefsson , bob@rattlesnake.com, emacs-devel@gnu.org, rms@gnu.org, monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 21 20:04:10 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CVx0M-00063I-00 for ; Sun, 21 Nov 2004 20:04:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVx9M-0002Ur-Vi for ged-emacs-devel@m.gmane.org; Sun, 21 Nov 2004 14:13:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CVx9A-0002Tu-0x for emacs-devel@gnu.org; Sun, 21 Nov 2004 14:13:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CVx99-0002So-BZ for emacs-devel@gnu.org; Sun, 21 Nov 2004 14:13:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVx98-0002SY-VD for emacs-devel@gnu.org; Sun, 21 Nov 2004 14:13:14 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CVwzv-0005WQ-Ro; Sun, 21 Nov 2004 14:03:44 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id iALJ3UFu010653; Sun, 21 Nov 2004 13:03:31 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id iALJ2QN21676; Sun, 21 Nov 2004 13:02:26 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rost@ias.edu In-reply-to: <200411210518.iAL5IKJg018118@haifa.math.ias.edu> (message from Markus Rost on Sun, 21 Nov 2004 00:18:20 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30203 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30203 Markus Rost wrote: > I installed the patch that Stefan sent, since the report > is that it worked well. > The installed patch doesn't work well for me. I think that one additional bogus line "goto exit;" slipped into it, see the following patch. This patch looks rather obvious to me, but since I am not a C programmer, I didn't install it myself. The second patch is Stefan's, which worked fine for me. ===Buffer *vc-diff*========================================= *** minibuf.c.~1.275.~ Sat Nov 20 23:37:08 2004 --- minibuf.c Sat Nov 20 23:55:30 2004 *************** *** 2105,2112 **** goto exit; } - goto exit; - /* Call do_completion, but ignore errors. */ SET_PT (ZV); val = internal_condition_case (complete_and_exit_1, Qerror, --- 2105,2110 ---- ============================================================ That patch _does_ look obvious and it fixes minibuffer completion problems reported by several people. That is, it makes `M-x she RET' work again. Sincerely, Luc.