From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: Simon Josefsson <jas@extundo.com>,
bob@rattlesnake.com, emacs-devel@gnu.org, rms@gnu.org,
monnier@iro.umontreal.ca
Subject: Re: completing-read case problem
Date: Sun, 21 Nov 2004 13:02:26 -0600 (CST) [thread overview]
Message-ID: <200411211902.iALJ2QN21676@raven.dms.auburn.edu> (raw)
In-Reply-To: <200411210518.iAL5IKJg018118@haifa.math.ias.edu> (message from Markus Rost on Sun, 21 Nov 2004 00:18:20 -0500)
Markus Rost wrote:
> I installed the patch that Stefan sent, since the report
> is that it worked well.
>
The installed patch doesn't work well for me.
I think that one additional bogus line "goto exit;" slipped into it,
see the following patch. This patch looks rather obvious to me, but
since I am not a C programmer, I didn't install it myself.
The second patch is Stefan's, which worked fine for me.
===Buffer *vc-diff*=========================================
*** minibuf.c.~1.275.~ Sat Nov 20 23:37:08 2004
--- minibuf.c Sat Nov 20 23:55:30 2004
***************
*** 2105,2112 ****
goto exit;
}
- goto exit;
-
/* Call do_completion, but ignore errors. */
SET_PT (ZV);
val = internal_condition_case (complete_and_exit_1, Qerror,
--- 2105,2110 ----
============================================================
That patch _does_ look obvious and it fixes minibuffer completion
problems reported by several people. That is, it makes `M-x she RET'
work again.
Sincerely,
Luc.
next prev parent reply other threads:[~2004-11-21 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411101929.iAAJThfq007309@haifa.math.ias.edu>
[not found] ` <E1CTDRk-00077r-Fr@fencepost.gnu.org>
[not found] ` <200411140703.iAE73Gd1019094@haifa.math.ias.edu>
2004-11-15 14:00 ` completing-read case problem Richard Stallman
2004-11-15 15:35 ` Lennart Borgman
2004-11-15 18:49 ` Kevin Rodgers
2004-11-15 20:19 ` Simon Josefsson
2004-11-15 22:06 ` Stefan Monnier
[not found] ` <jwvu0rrgm27.fsf-monnier+emacs@gnu.org>
2004-11-15 19:43 ` Markus Rost
2004-11-15 23:07 ` Luc Teirlinck
2004-11-16 2:52 ` Markus Rost
2004-11-21 1:10 ` Richard Stallman
2004-11-21 5:18 ` Markus Rost
2004-11-21 19:02 ` Luc Teirlinck [this message]
2004-11-22 14:07 ` Richard Stallman
2004-11-16 4:00 Markus Rost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411211902.iALJ2QN21676@raven.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
--cc=bob@rattlesnake.com \
--cc=emacs-devel@gnu.org \
--cc=jas@extundo.com \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).