From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel,gmane.emacs.w3m Subject: Re: bogus change(s) in cl-macs.el Date: Thu, 18 Nov 2004 21:41:11 -0600 (CST) Message-ID: <200411190341.iAJ3fB711866@raven.dms.auburn.edu> References: NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100835797 11698 80.91.229.6 (19 Nov 2004 03:43:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2004 03:43:17 +0000 (UTC) Cc: emacs-w3m@namazu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 19 04:43:06 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CUzfu-0000Rl-00 for ; Fri, 19 Nov 2004 04:43:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUzom-00047D-EG for ged-emacs-devel@m.gmane.org; Thu, 18 Nov 2004 22:52:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUzoO-00046l-Fc for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:51:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUzoN-00046F-Cz for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:51:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUzoN-00045y-9W for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:51:51 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUzf1-00014p-3k for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:42:11 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id iAJ3g9Fu024180; Thu, 18 Nov 2004 21:42:10 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id iAJ3fB711866; Thu, 18 Nov 2004 21:41:11 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: yamaoka@jpl.org In-reply-to: (message from Katsumi Yamaoka on Fri, 19 Nov 2004 12:06:35 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30063 gmane.emacs.w3m:4542 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30063 Katsumi Yamaoka wrote: First of all, I protest strongly that such a big change has not been recorded on the ChangeLog file. Second, the change at least to the `labels' macro breaks emacs-w3m. Emacs-w3m uses some cl macros including `labels' in order to work together with the external w3m command asynchronously. The patch below should be applied. Third, I'm not sure whether a problem is limited only to it. It was not me who installed that change to cl-macs, but I believe that it was made in response to problems with compiler warnings I reported. I myself suggested the following alternate type solution, which I believe would not have broken anything: ! (let ((var (with-no-warnings (gensym)))) but after I saw Stefan's patch, I did not pursue (and did not double check) this. I could still do it given that Stefan's solution seems to give problems. It would eliminate the compiler warnings with no side effects. I guess that this should be done everywhere since if the change breaks things in one place, it probably does in other places too. I could post a patch for review, if desired. I do not immediately understand why Stefan's patch breaks things. It fails to adjoin a unique identifying number, like gensym does, but I do not understand why that is necessary. Distinct uninterned symbols with the same name are still distinct. I guess that if I knew the cl package better, I would understand. Sincerely, Luc.