From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: emacs-w3m@namazu.org, emacs-devel@gnu.org
Subject: Re: bogus change(s) in cl-macs.el
Date: Thu, 18 Nov 2004 21:41:11 -0600 (CST) [thread overview]
Message-ID: <200411190341.iAJ3fB711866@raven.dms.auburn.edu> (raw)
In-Reply-To: <b9y4qjmwn9g.fsf@jpl.org> (message from Katsumi Yamaoka on Fri, 19 Nov 2004 12:06:35 +0900)
Katsumi Yamaoka wrote:
First of all, I protest strongly that such a big change has not
been recorded on the ChangeLog file. Second, the change at least
to the `labels' macro breaks emacs-w3m. Emacs-w3m uses some cl
macros including `labels' in order to work together with the
external w3m command asynchronously. The patch below should be
applied. Third, I'm not sure whether a problem is limited only
to it.
It was not me who installed that change to cl-macs, but I believe that
it was made in response to problems with compiler warnings I reported.
I myself suggested the following alternate type solution, which I
believe would not have broken anything:
! (let ((var (with-no-warnings (gensym))))
but after I saw Stefan's patch, I did not pursue (and did not double
check) this. I could still do it given that Stefan's solution seems
to give problems. It would eliminate the compiler warnings with no
side effects. I guess that this should be done everywhere since if
the change breaks things in one place, it probably does in other
places too. I could post a patch for review, if desired.
I do not immediately understand why Stefan's patch breaks things. It
fails to adjoin a unique identifying number, like gensym does, but I
do not understand why that is necessary. Distinct uninterned symbols
with the same name are still distinct. I guess that if I knew the cl
package better, I would understand.
Sincerely,
Luc.
next prev parent reply other threads:[~2004-11-19 3:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 3:06 bogus change(s) in cl-macs.el Katsumi Yamaoka
2004-11-19 3:41 ` Luc Teirlinck [this message]
2004-11-19 3:51 ` Miles Bader
2004-11-19 4:21 ` Luc Teirlinck
2004-11-19 3:48 ` Miles Bader
2004-11-19 3:59 ` Katsumi Yamaoka
2004-11-19 5:55 ` [emacs-w3m:07185] " Katsumi Yamaoka
2004-11-19 7:10 ` Stefan Monnier
2004-11-19 20:04 ` Richard Stallman
2004-11-26 2:17 ` Katsumi Yamaoka
2004-11-26 4:03 ` Stefan Monnier
2004-11-26 5:18 ` Katsumi Yamaoka
2004-11-26 23:51 ` Stefan Monnier
2004-11-19 5:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411190341.iAJ3fB711866@raven.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
--cc=emacs-devel@gnu.org \
--cc=emacs-w3m@namazu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).