nnml.el and nnfolder.el

nnml.el and nnfolder.el

[Luc Teirlinck]

I believe that the following two compiler warnings in the `make
bootstrap' output seem real:

    In nnfolder-save-marks: nnfolder.el:1243:19:Warning: `error' called
    with 1 args to fill 2 format field(s)

and:

    nnml.el:987:19:Warning: `error' called with 1 args to fill 2
    format field(s)

They probably resulted from typos.  I know nothing about those two
files and do not remember what procedure to follow for bug fixes to
Gnus, but I would guess that the following were really intended:

===File ~/nnfolder-diff=====================================
*** nnfolder.el	29 Sep 2004 07:46:22 -0500	1.18
--- nnfolder.el	14 Nov 2004 14:51:13 -0600	
***************
*** 1240,1246 ****
  			nnfolder-marks-modtime))
        (error (or (gnus-yes-or-no-p
  		  (format "Could not write to %s (%s).  Continue? " file err))
! 		 (error "Cannot write to %s (%s)" err))))))
  
  (defun nnfolder-open-marks (group server)
    (let ((file (nnfolder-group-marks-pathname group)))
--- 1240,1246 ----
  			nnfolder-marks-modtime))
        (error (or (gnus-yes-or-no-p
  		  (format "Could not write to %s (%s).  Continue? " file err))
! 		 (error "Cannot write to %s (%s)" file err))))))
  
  (defun nnfolder-open-marks (group server)
    (let ((file (nnfolder-group-marks-pathname group)))
============================================================

===File ~/nnml-diff=========================================
*** nnml.el	29 Sep 2004 07:46:22 -0500	1.13
--- nnml.el	14 Nov 2004 15:02:39 -0600	
***************
*** 984,990 ****
  			nnml-marks-modtime))
        (error (or (gnus-yes-or-no-p
  		  (format "Could not write to %s (%s).  Continue? " file err))
! 		 (error "Cannot write to %s (%s)" err))))))
  
  (defun nnml-open-marks (group server)
    (let ((file (expand-file-name
--- 984,990 ----
  			nnml-marks-modtime))
        (error (or (gnus-yes-or-no-p
  		  (format "Could not write to %s (%s).  Continue? " file err))
! 		 (error "Cannot write to %s (%s)" file err))))))
  
  (defun nnml-open-marks (group server)
    (let ((file (expand-file-name
============================================================

Re: nnml.el and nnfolder.el

[Reiner Steib]

On Sun, Nov 14 2004, Luc Teirlinck wrote:

> I believe that the following two compiler warnings in the `make
> bootstrap' output seem real:
>
>     In nnfolder-save-marks: nnfolder.el:1243:19:Warning: `error' called
>     with 1 args to fill 2 format field(s)
>
> and:
>
>     nnml.el:987:19:Warning: `error' called with 1 args to fill 2
>     format field(s)
>
> They probably resulted from typos.  I know nothing about those two
> files and do not remember what procedure to follow for bug fixes to
> Gnus, 

You can apply bug fixes to Gnus in Emacs trunk.  Miles will sync the
changes to Gnus trunk and the stable branch (v5-10) within a couple of
days.

> but I would guess that the following were really intended:
[...]

The patch is correct, I think.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: nnml.el and nnfolder.el

[Luc Teirlinck]

Reiner Steib wrote:

   The patch is correct, I think.

Thanks.  I have installed it in Emacs CVS.

Sincerely,

Luc.

Re: nnml.el and nnfolder.el

[Miles Bader]

On Sun, Nov 14, 2004 at 11:36:39PM +0100, Reiner Steib wrote:
> > They probably resulted from typos.  I know nothing about those two
> > files and do not remember what procedure to follow for bug fixes to
> > Gnus, 
> 
> You can apply bug fixes to Gnus in Emacs trunk.

I'm presuming that Luc was referring to getting confirmation about changes to
unfamiliar code.

I'd guess it's enough to post here (emacs-devel), since several Gnus
maintainers read this list (at least Reiner).

-Miles
-- 
P.S.  All information contained in the above letter is false,
      for reasons of military security.