From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: defconst in lao.el Date: Sun, 14 Nov 2004 15:47:56 -0600 (CST) Message-ID: <200411142147.iAELlux27413@raven.dms.auburn.edu> References: <200411141856.iAEIuEM24284@raven.dms.auburn.edu> <87ekiw2lbk.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100468959 21421 80.91.229.6 (14 Nov 2004 21:49:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 14 Nov 2004 21:49:19 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 14 22:49:13 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CTSFF-0000ZA-00 for ; Sun, 14 Nov 2004 22:49:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTSNu-0007Fh-Tu for ged-emacs-devel@m.gmane.org; Sun, 14 Nov 2004 16:58:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CTSNm-0007Fb-0V for emacs-devel@gnu.org; Sun, 14 Nov 2004 16:58:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CTSNl-0007FP-Kx for emacs-devel@gnu.org; Sun, 14 Nov 2004 16:58:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTSNl-0007FM-IG for emacs-devel@gnu.org; Sun, 14 Nov 2004 16:58:01 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CTSEm-0008Bf-OO for emacs-devel@gnu.org; Sun, 14 Nov 2004 16:48:44 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id iAELmiFu011257; Sun, 14 Nov 2004 15:48:44 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id iAELlux27413; Sun, 14 Nov 2004 15:47:56 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: monnier@iro.umontreal.ca In-reply-to: <87ekiw2lbk.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 14 Nov 2004 16:06:24 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29836 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29836 Stefan Monnier wrote: > @@ -42,7 +42,7 @@ > (compose-string (quail-lookup-map-and-concat quail-current-key)))) > control-flag) > > -(defconst lao-key-alist > +(defvar lao-key-alist > '(("!" . "1") > ("\"" . "=") > ("#" . "3") This one also looks wrong: this is treated as a constant as far as I can tell. This is again difficult to say, since for all related variables the defconst was clearly wrong. It indeed is less clear for this one and it produces no compiler warnings. Again, I will _keep_ the defconst, to err on the consevative side in terms of making changes to code that I am not really terribly familiar with. Sincerely, Luc.