From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: passing arg of `merge_face_heights' makes integer from pointer without a cast Date: Fri, 5 Nov 2004 17:34:01 -0500 Message-ID: <20041105223401.GA2206@fencepost> References: <20041104211651.GA22409@fencepost> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099702115 18422 80.91.229.6 (6 Nov 2004 00:48:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 6 Nov 2004 00:48:35 +0000 (UTC) Cc: schwab@suse.de, emacs-devel@gnu.org, Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 06 01:48:23 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CQEkh-0006qe-00 for ; Sat, 06 Nov 2004 01:48:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CQEsv-0005gK-2j for ged-emacs-devel@m.gmane.org; Fri, 05 Nov 2004 19:56:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CQEsm-0005fC-8l for emacs-devel@gnu.org; Fri, 05 Nov 2004 19:56:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CQEsl-0005es-I5 for emacs-devel@gnu.org; Fri, 05 Nov 2004 19:56:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CQEsl-0005ei-DV for emacs-devel@gnu.org; Fri, 05 Nov 2004 19:56:43 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CQEkR-0000a2-N6 for emacs-devel@gnu.org; Fri, 05 Nov 2004 19:48:07 -0500 Original-Received: from miles by fencepost.gnu.org with local (Exim 4.34) id 1CQCef-0001BN-Pv; Fri, 05 Nov 2004 17:34:07 -0500 Original-To: Richard Stallman Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Blat: Foop X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29464 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29464 On Fri, Nov 05, 2004 at 10:01:47AM -0500, Richard Stallman wrote: > If they are allocated in the stack, then it should be easy to > explicitly gcpro the Lisp_Object in each one. Just do that in the > frame that allocates the struct. Doesn't that do the job this > gcpro argument was intended to do? That would probably be fine (I think there's only one place where it needs to be done). The GCPRO argument to merge_face_heights can probably just be deleted -- all other uses just pass Qnil. -Miles -- In New York, most people don't have cars, so if you want to kill a person, you have to take the subway to their house. And sometimes on the way, the train is delayed and you get impatient, so you have to kill someone on the subway. [George Carlin]