unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Masatake YAMATO <jet@gyve.org>
Cc: emacs-devel@gnu.org
Subject: type of port of url
Date: Wed, 27 Oct 2004 14:18:08 +0900 (JST)	[thread overview]
Message-ID: <20041027.141808.202854715.jet@gyve.org> (raw)

Dear, Sir

I'm trying your url package.
I have a question about the port slot of url object passed to 
url-protocol, e.g. url-irc.

Is the port a string or integer?

In the function, url-irc, it seems that url-port is expected to return a string.
However, it returns an integer. Attached patch is required to use url-irc.el.

string-to-int is also used in some other places in url packages to
convert the type of port. 

Masatake YAMATO

Index: lisp/url/url-irc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/url/url-irc.el,v
retrieving revision 1.5
diff -u -r1.5 url-irc.el
--- lisp/url/url-irc.el	19 Oct 2004 21:36:00 -0000	1.5
+++ lisp/url/url-irc.el	27 Oct 2004 05:14:04 -0000
@@ -61,7 +61,9 @@
 ;;;###autoload
 (defun url-irc (url)
   (let* ((host (url-host url))
-	 (port (string-to-int (url-port url)))
+	 (port (if (stringp port)
+		   (string-to-int (url-port url))
+		 (url-port url)))
 	 (pass (url-password url))
 	 (user (url-user url))
 	 (chan (url-filename url)))

             reply	other threads:[~2004-10-27  5:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  5:18 Masatake YAMATO [this message]
2004-10-28  6:25 ` type of port of url Richard Stallman
2004-11-01 17:40   ` Masatake YAMATO
2004-11-11 18:09 ` running mm-destroy-parts when (mm-display-part handle) returns inline Masatake YAMATO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027.141808.202854715.jet@gyve.org \
    --to=jet@gyve.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).