unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* query-replace-interactive
@ 2004-10-11  1:10 Luc Teirlinck
  2004-10-11  1:18 ` query-replace-interactive Luc Teirlinck
  0 siblings, 1 reply; 21+ messages in thread
From: Luc Teirlinck @ 2004-10-11  1:10 UTC (permalink / raw)


A while ago, I converted `query-replace-interactive' into a defcustom,
after it was decided to do so after discussion on emacs-devel.  I just
noticed that this change was reverted in version 1.181.  The Change
Log does not mention the reversion.  It only says that the `initial'
special value was removed.  Therefore, I assume that the reversion was
accidental.

Unless there are objections, I will make `query-replace-interactive'
into a defcustom again, since we agreed on that.

Sincerely,

Luc.

^ permalink raw reply	[flat|nested] 21+ messages in thread
* query-replace-interactive
@ 2004-07-03 22:59 Stefan
  2004-07-04  9:54 ` query-replace-interactive Juri Linkov
  0 siblings, 1 reply; 21+ messages in thread
From: Stefan @ 2004-07-03 22:59 UTC (permalink / raw)



Is the added complexity of (eq query-replace-interactive 'initial) really
worth it ?
For one, it has an unusual behavior (the Emacs way would be not
to put it as INITIAL but as DEFAULT and to place it in the prompt as
"Replace (default foo): ").
For two, it's only used for isearch-query-replace and in my experience this
additional prompt is just an annoyance: if I hit M-% in isearch I really
want to replace the currently matched text.

So I suggest we back out this introduction of an `initial' value of
query-replace-interactive.  I also incidentally suggest that
isearch-query-replace don't do (call-interactively 'query-replace) but
use (perform-replace isearch-string nil t isearch-regexp isearch-word)
instead.

If really someone is in isearch and wants to do a query-replace on
something else than what he's currently searching, he can do RET M-%.

After all, we already agreed that M-% in isearch should obey the
isearch-regexp.


        Stefan

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2004-10-11  1:18 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-11  1:10 query-replace-interactive Luc Teirlinck
2004-10-11  1:18 ` query-replace-interactive Luc Teirlinck
  -- strict thread matches above, loose matches on Subject: below --
2004-07-03 22:59 query-replace-interactive Stefan
2004-07-04  9:54 ` query-replace-interactive Juri Linkov
2004-07-04 16:13   ` query-replace-interactive Stefan
2004-07-05  6:08     ` query-replace-interactive Juri Linkov
2004-07-05 12:44       ` query-replace-interactive Stefan
2004-07-06  9:56         ` query-replace-interactive Juri Linkov
2004-07-06 22:00           ` query-replace-interactive Richard Stallman
2004-07-07  5:11             ` query-replace-interactive Juri Linkov
2004-07-07  5:42               ` query-replace-interactive Miles Bader
2004-07-07  9:35               ` query-replace-interactive David Kastrup
2004-07-07 20:58               ` query-replace-interactive Richard Stallman
2004-07-06 22:00           ` query-replace-interactive Richard Stallman
2004-07-06 22:11             ` query-replace-interactive David Kastrup
2004-07-06 11:53       ` query-replace-interactive Richard Stallman
2004-07-06 12:24         ` query-replace-interactive Stefan
2004-07-07  6:41           ` query-replace-interactive Richard Stallman
2004-07-06 11:53       ` query-replace-interactive Richard Stallman
2004-07-06 12:09         ` query-replace-interactive David Kastrup
2004-07-07  6:41           ` query-replace-interactive Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).