unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Patch for bug in facemenu.el
@ 2004-09-02  1:52 Luc Teirlinck
  2004-09-02  1:56 ` Luc Teirlinck
  0 siblings, 1 reply; 2+ messages in thread
From: Luc Teirlinck @ 2004-09-02  1:52 UTC (permalink / raw)
  Cc: Boris Goldowsky

Do `emacs -q'

C-x C-f enr.text  M-x enriched-mode

Insert: qqq

C-x h
M-g l

Now all q's are in bold italic.

C-x h
M-x facemenu-set-foreground RET green

Now the q's are green, but no longer bold or italic.

I believe that this is a bug.

The following small patch would fix this.

===File ~/facemenu.el-diff==================================
*** facemenu.el	20 May 2004 12:11:30 -0500	1.72
--- facemenu.el	01 Sep 2004 17:39:21 -0500	
***************
*** 617,623 ****
  		       (check-face (car face-list)))))
  		(i mask-len)
  		(useful nil))
! 	    (while (> (setq i (1- i)) 1)
  	      (and (not (memq (aref face-atts i) '(nil unspecified)))
  		   (memq (aref mask-atts i) '(nil unspecified))
  		   (aset mask-atts i (setq useful t))))
--- 617,623 ----
  		       (check-face (car face-list)))))
  		(i mask-len)
  		(useful nil))
! 	    (while (>= (setq i (1- i)) 0)
  	      (and (not (memq (aref face-atts i) '(nil unspecified)))
  		   (memq (aref mask-atts i) '(nil unspecified))
  		   (aset mask-atts i (setq useful t))))
============================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patch for bug in facemenu.el
  2004-09-02  1:52 Patch for bug in facemenu.el Luc Teirlinck
@ 2004-09-02  1:56 ` Luc Teirlinck
  0 siblings, 0 replies; 2+ messages in thread
From: Luc Teirlinck @ 2004-09-02  1:56 UTC (permalink / raw)
  Cc: boris, emacs-devel

>From my previous message:

   The following small patch would fix this.

I forgot to say that, of course, I can install this if it looks OK.

Sincerely,

Luc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-02  1:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-02  1:52 Patch for bug in facemenu.el Luc Teirlinck
2004-09-02  1:56 ` Luc Teirlinck

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).