From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Patch for bug in facemenu.el Date: Wed, 1 Sep 2004 20:52:12 -0500 (CDT) Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <200409020152.i821qC609788@gecko.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1094090037 13064 80.91.224.253 (2 Sep 2004 01:53:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 2 Sep 2004 01:53:57 +0000 (UTC) Cc: Boris Goldowsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 02 03:53:49 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C2gnN-0005Xp-00 for ; Thu, 02 Sep 2004 03:53:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C2gsK-0007BV-5k for ged-emacs-devel@m.gmane.org; Wed, 01 Sep 2004 21:58:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C2grn-00071h-Vs for emacs-devel@gnu.org; Wed, 01 Sep 2004 21:58:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C2grm-00071C-9g for emacs-devel@gnu.org; Wed, 01 Sep 2004 21:58:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C2grm-000719-6O for emacs-devel@gnu.org; Wed, 01 Sep 2004 21:58:22 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C2glx-0000lC-Qv; Wed, 01 Sep 2004 21:52:22 -0400 Original-Received: from gecko.dms.auburn.edu (gecko.dms.auburn.edu [131.204.53.5]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i821qKuE016778; Wed, 1 Sep 2004 20:52:21 -0500 (CDT) Original-Received: (from teirllm@localhost) by gecko.dms.auburn.edu (8.11.7p1+Sun/8.11.6) id i821qC609788; Wed, 1 Sep 2004 20:52:12 -0500 (CDT) X-Authentication-Warning: gecko.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26712 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26712 Do `emacs -q' C-x C-f enr.text M-x enriched-mode Insert: qqq C-x h M-g l Now all q's are in bold italic. C-x h M-x facemenu-set-foreground RET green Now the q's are green, but no longer bold or italic. I believe that this is a bug. The following small patch would fix this. ===File ~/facemenu.el-diff================================== *** facemenu.el 20 May 2004 12:11:30 -0500 1.72 --- facemenu.el 01 Sep 2004 17:39:21 -0500 *************** *** 617,623 **** (check-face (car face-list))))) (i mask-len) (useful nil)) ! (while (> (setq i (1- i)) 1) (and (not (memq (aref face-atts i) '(nil unspecified))) (memq (aref mask-atts i) '(nil unspecified)) (aset mask-atts i (setq useful t)))) --- 617,623 ---- (check-face (car face-list))))) (i mask-len) (useful nil)) ! (while (>= (setq i (1- i)) 0) (and (not (memq (aref face-atts i) '(nil unspecified))) (memq (aref mask-atts i) '(nil unspecified)) (aset mask-atts i (setq useful t)))) ============================================================