From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: emacs-devel@gnu.org
Subject: Re: speedbar.el makes bootstrapping fail.
Date: Sun, 22 Aug 2004 17:14:06 -0500 (CDT) [thread overview]
Message-ID: <200408222214.i7MME6408404@raven.dms.auburn.edu> (raw)
In-Reply-To: <200408222003.i7MK3m107911@raven.dms.auburn.edu> (message from Luc Teirlinck on Sun, 22 Aug 2004 15:03:48 -0500 (CDT))
I have committed my patch now.
>From my previous message:
I am hesitant to put a `with-no-warnings' around the defcustom,
because the elisp manual says that def{var,const,custom} should be at
top level.
I realize now that this was stupid. I do not know why I was thinking
that I had to put the `with-no-warnings' around the entire defcustom.
I only have to put it around one single setq.
The following patch is an alternative to the one I installed. It is
made vs the now committed version. I could install it if desired. I
will wait for reactions however. Bootstrapping works now and the
issue is purely stylistic. If Richard was trying to do more than just
avoid a compiler warning, then a more fundamental change is needed.
===File ~/speedbar.el-diff==================================
*** speedbar.el 22 Aug 2004 14:58:16 -0500 1.58
--- speedbar.el 22 Aug 2004 16:31:54 -0500
***************
*** 665,673 ****
"*Regexp matching files we don't want displayed in a speedbar buffer.
It is generated from the variable `completion-ignored-extensions'")
- ;; Ugly compiler silencing trick. The real defvar comes later in this file.
- (defvar speedbar-file-regexp)
-
;; this is dangerous to customize, because the defaults will probably
;; change in the future.
(defcustom speedbar-supported-extension-expressions
--- 665,670 ----
***************
*** 691,698 ****
:version "21.1"
:type '(repeat (regexp :tag "Extension Regexp"))
:set (lambda (sym val)
! (setq speedbar-supported-extension-expressions val
! speedbar-file-regexp (speedbar-extension-list-to-regex val))))
(defvar speedbar-file-regexp
(speedbar-extension-list-to-regex speedbar-supported-extension-expressions)
--- 688,696 ----
:version "21.1"
:type '(repeat (regexp :tag "Extension Regexp"))
:set (lambda (sym val)
! (setq speedbar-supported-extension-expressions val)
! (with-no-warnings
! (setq speedbar-file-regexp (speedbar-extension-list-to-regex val)))))
(defvar speedbar-file-regexp
(speedbar-extension-list-to-regex speedbar-supported-extension-expressions)
============================================================
next prev parent reply other threads:[~2004-08-22 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 20:03 speedbar.el makes bootstrapping fail Luc Teirlinck
2004-08-22 20:07 ` Luc Teirlinck
2004-08-22 22:14 ` Luc Teirlinck [this message]
2004-08-23 7:57 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408222214.i7MME6408404@raven.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).