From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: time values Date: Sun, 11 Jul 2004 10:37:21 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200407111537.i6BFbLe09250@raven.dms.auburn.edu> References: <200407110033.i6B0XLF08165@raven.dms.auburn.edu> <86llhrq7ed.fsf@rumba.de.uu.net> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1089560425 17516 80.91.224.253 (11 Jul 2004 15:40:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Jul 2004 15:40:25 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jul 11 17:40:19 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjgR9-0002w1-00 for ; Sun, 11 Jul 2004 17:40:19 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjgR9-0004F5-00 for ; Sun, 11 Jul 2004 17:40:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BjgTQ-0004oI-6F for emacs-devel@quimby.gnus.org; Sun, 11 Jul 2004 11:42:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BjgTJ-0004oC-Kg for emacs-devel@gnu.org; Sun, 11 Jul 2004 11:42:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BjgTI-0004o0-5b for emacs-devel@gnu.org; Sun, 11 Jul 2004 11:42:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BjgTI-0004nx-1b for emacs-devel@gnu.org; Sun, 11 Jul 2004 11:42:32 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BjgQq-0006Nz-7s for emacs-devel@gnu.org; Sun, 11 Jul 2004 11:40:00 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i6BFdwuE013755; Sun, 11 Jul 2004 10:39:59 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i6BFbLe09250; Sun, 11 Jul 2004 10:37:21 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: kai@emptydomain.de In-reply-to: <86llhrq7ed.fsf@rumba.de.uu.net> (message from Kai Grossjohann on Sun, 11 Jul 2004 10:23:38 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25582 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25582 >>From my previous message: By the way, your current code seems to assume that `visited-file-modtime' is not 0. Are you sure of that? Of course, you know that (nth 5 attr) is not (0 0), but still. My patch still probably assumes that: can tramp-time-diff handle 0 as an argument? Otherwise, it is easy to rewrite the patch to transform 0 into (0 0), or maybe an integer N < 2**16 into (0 N), because, theoretically, `visited-file-modtime' can return such integers. (Even though probably not in practice). But maybe `tramp-time-diff' is the place to actually do that. I was confused there for a moment. If `visited-file-modtime' returns 0, `verify-visited-file-modtime' and hence `tramp-handle-verify-visited-file-modtime' should return t. Hence, it has to be handled specially by `tramp-handle-verify-visited-file-modtime'. So the only question is: Are you sure that the value can not be 0 at that point? Your current code assumes it is not. There probably is no need to worry about positive return values < 2**16, as these are not going to occur in practice. Sincerely, Luc.