From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Delayed loading of image libraries Date: Thu, 01 Jul 2004 12:13:47 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040701120343.4161.JMBARRANQUERO@wke.es> References: <20040701110632.415E.JMBARRANQUERO@wke.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1088676895 18788 80.91.224.253 (1 Jul 2004 10:14:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Jul 2004 10:14:55 +0000 (UTC) Cc: Andreas Schwab , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Jul 01 12:14:45 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bfyab-0005GP-00 for ; Thu, 01 Jul 2004 12:14:45 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bfyaa-0004nj-00 for ; Thu, 01 Jul 2004 12:14:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BfycL-0003Hz-I7 for emacs-devel@quimby.gnus.org; Thu, 01 Jul 2004 06:16:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bfyc1-00039r-Gc for emacs-devel@gnu.org; Thu, 01 Jul 2004 06:16:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bfybz-00038E-DY for emacs-devel@gnu.org; Thu, 01 Jul 2004 06:16:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bfybz-00037w-6K for emacs-devel@gnu.org; Thu, 01 Jul 2004 06:16:11 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BfyZf-0001GI-Sb; Thu, 01 Jul 2004 06:13:48 -0400 Original-Received: from [172.17.221.23] (JMBARRANQUERO [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id NZ3RGC3S; Thu, 1 Jul 2004 12:12:17 +0200 Original-To: Miles Bader In-Reply-To: X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25351 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25351 On Thu, 01 Jul 2004 18:48:46 +0900 Miles Bader wrote: > Images are (currently) perfectly valid lisp values; if we don't want > them to be readable and writable to files, we should make them an opaque > type. Reading and writing a lisp value (whether an image, or any other kind) does not need image support. *Processing* one of such values as an image (to display it, ask questions about it, etc.) does need it. At that point, code should've asked whether the image type was available. I'm not sure why you do conflate reading/writing with using-as-an-image (even if loading an image-representing lisp value ends up displaying it). > But that seems like a stupid thing to do. Just make the C code deal > with the situation. If my patch was wrong (though I admit, I still have > no idea why ??? init-image-library has two mandatory arguments. You didn't pass the second one: the alist specifying where to find the dynamic libraries supporting the desired image type. >-- your discussion so far doesn't make much sense to me), Why? Lack of English skills, (absence of) clarity, vocabulary mismatch? > fix it, but don't remove the functionality it adds. I'm not trying to remove any functionality. Honest. I'm trying to know where should it be implemented. > [Note that reading and writing images to files (and displaying them in a > new emacs instance, by just reading the file) worked fine before the > changes that added Finit_image_library etc., so the bug I fixed is a > regression.] There's no doubt that it must be fixed. Currently, it is not (my Emacs crashes on displaying TIFFs). I'll repeat one of my questions, not for you in particular, but for anyone who knows: Why can lookup_image_type return NULL? Juanma