From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Delayed loading of image libraries Date: Wed, 30 Jun 2004 15:00:30 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040630142515.BD13.JMBARRANQUERO@wke.es> References: <20040630132923.BD10.JMBARRANQUERO@wke.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1088600624 803 80.91.224.253 (30 Jun 2004 13:03:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 30 Jun 2004 13:03:44 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jun 30 15:03:38 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BfekU-00084A-00 for ; Wed, 30 Jun 2004 15:03:38 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BfekN-0000Ec-00 for ; Wed, 30 Jun 2004 15:03:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bfelw-00062c-Bh for emacs-devel@quimby.gnus.org; Wed, 30 Jun 2004 09:05:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BfekI-0005nl-Ul for emacs-devel@gnu.org; Wed, 30 Jun 2004 09:03:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BfekA-0005kN-UU for emacs-devel@gnu.org; Wed, 30 Jun 2004 09:03:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BfekA-0005kI-Q7 for emacs-devel@gnu.org; Wed, 30 Jun 2004 09:03:18 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BfeiP-0003ng-Ec for emacs-devel@gnu.org; Wed, 30 Jun 2004 09:01:30 -0400 Original-Received: from [172.17.221.23] (JMBARRANQUERO [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id NZ3RF60H; Wed, 30 Jun 2004 14:59:04 +0200 Original-To: Andreas Schwab In-Reply-To: X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25329 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25329 On Wed, 30 Jun 2004 13:41:51 +0200 Andreas Schwab wrote: > Would Qnil be valid in this context? Certainly for !HAVE_NTGUI, but would > that work for HAVE_NTGUI? Passing Qnil should work. However, Miles' change doesn't seem to be right, even when passing Qnil to Finit_image_library. make_image does: img->type = lookup_image_type (image_spec_value (spec, QCtype, NULL)); xassert (img->type != NULL); and, from what I gather, xassert can be a null op**, in which case an image is built with a non-valid type. In fact, I'm not sure why lookup_image_type is supposed to allow returning NULL. It is an internal function to map image type symbols to image type structs, so the image type symbol validation should be done at a higher level (before calling lookup_image_type). **BTW, what is xassert supposed to do? On dispextern.h it is a null op unless GLYPH_DEBUG is defined; and fontset.c has its own definition. Juanma