From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Delayed loading of image libraries Date: Wed, 30 Jun 2004 13:13:25 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040630123512.BD0D.JMBARRANQUERO@wke.es> References: <20040610133420.CAC7.JMBARRANQUERO@wke.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1088594045 16008 80.91.224.253 (30 Jun 2004 11:14:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 30 Jun 2004 11:14:05 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jun 30 13:13:55 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bfd2I-0000pV-00 for ; Wed, 30 Jun 2004 13:13:54 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bfd2I-0006mO-00 for ; Wed, 30 Jun 2004 13:13:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bfd40-0007Q7-8K for emacs-devel@quimby.gnus.org; Wed, 30 Jun 2004 07:15:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bfd3x-0007Q0-Ks for emacs-devel@gnu.org; Wed, 30 Jun 2004 07:15:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bfd3w-0007Ph-08 for emacs-devel@gnu.org; Wed, 30 Jun 2004 07:15:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bfd3v-0007Pe-SK for emacs-devel@gnu.org; Wed, 30 Jun 2004 07:15:35 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bfd1t-00039s-HZ for emacs-devel@gnu.org; Wed, 30 Jun 2004 07:13:29 -0400 Original-Received: from [172.17.221.23] (JMBARRANQUERO [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id NZ3RF61X; Wed, 30 Jun 2004 13:11:59 +0200 Original-To: Andreas Schwab , emacs-devel@gnu.org In-Reply-To: X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25324 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25324 On Wed, 30 Jun 2004 12:15:29 +0200 Andreas Schwab wrote: > Please make libraries an explicit parameter of CHECK_LIB_AVAILABLE, so > that it does not look like it is completely ignored. Well, it is a matter of taste. Hidding things is not good, but redundant info is not good either, and in this case, there's no way CHECK_LIB_AVAILABLE is ever gonna get passed anything but `libraries'. Also, CHECK_LIB_AVAILABLE is defined just above init-image-library; it takes only a cursory look to notice that `libraries' is being used. I'd agree with you if CHECK_LIB_AVAILABLE were defined in an include file, or at the top of image.c. > Also, you are > missing to declare the parameters. You're right; thanks for noticing. > Please always compile with -Wall. I'll try to remember, if I ever compile with GCC. For MSVC, I'm using the default warnings (default, as set up by nt/configure.bat, I mean); with these, there's no warning for the missing parameter declarations. Juanma