From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: isearch hooks (was: query-replace-interactive not documented) Date: Fri, 18 Jun 2004 21:10:05 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040619011005.GA2240@fencepost> References: <20040528.181649.25475113.wl@gnu.org> <200405291737.i4THbPJ06689@raven.dms.auburn.edu> <878yeyczec.fsf@mail.jurta.org> <87n03aa4jk.fsf@mail.jurta.org> <87d63wy6ux.fsf_-_@mail.jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1087607450 13991 80.91.224.253 (19 Jun 2004 01:10:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 19 Jun 2004 01:10:50 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Jun 19 03:10:45 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BbUNZ-0006bK-00 for ; Sat, 19 Jun 2004 03:10:45 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BbUNY-0001kV-00 for ; Sat, 19 Jun 2004 03:10:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BbUOg-0000Jw-8H for emacs-devel@quimby.gnus.org; Fri, 18 Jun 2004 21:11:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BbUOY-0000Iv-L2 for emacs-devel@gnu.org; Fri, 18 Jun 2004 21:11:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BbUOY-0000If-6t for emacs-devel@gnu.org; Fri, 18 Jun 2004 21:11:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BbUOY-0000IY-3r for emacs-devel@gnu.org; Fri, 18 Jun 2004 21:11:46 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BbUN2-0005zr-53 for emacs-devel@gnu.org; Fri, 18 Jun 2004 21:10:12 -0400 Original-Received: from miles by fencepost.gnu.org with local (Exim 4.34) id 1BbUMv-0001p1-6r; Fri, 18 Jun 2004 21:10:05 -0400 Original-To: Juri Linkov Content-Disposition: inline In-Reply-To: <87d63wy6ux.fsf_-_@mail.jurta.org> User-Agent: Mutt/1.3.28i Blat: Foop X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25095 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25095 On Fri, Jun 18, 2004 at 11:00:09PM +0300, Juri Linkov wrote: > The patch below adds two hooks `isearch-wrapped-hook' and > `isearch-failed-hook'. I like the idea, but a few comments: (1) I'm a bit confused about why there should be two hooks -- both are really instances of search failure, right? Can they be combined? (2) The name `isearch-wrapped-hook' seems wrong anyway: the hook appears to be an _alternative_ to wrapping, not something that runs _after_ wrapping, so something like `isearch-wrap-hook' seems more appropriate, (if this hook cannot be combined with the other hook). (3) It seems that these should be `-function' variables, not `-hook' variables, as they modify behavior instead of merely extending it, and multiple entries don't seem likely to work correctly. (4) Should the code set `isearch-wrapped' even when the user-function is run instead of the default code? Thanks, -Miles -- `...the Soviet Union was sliding in to an economic collapse so comprehensive that in the end its factories produced not goods but bads: finished products less valuable than the raw materials they were made from.' [The Economist]