From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Werner LEMBERG Newsgroups: gmane.emacs.devel Subject: bug in comment-region Date: Wed, 09 Jun 2004 15:36:07 +0200 (CEST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040609.153607.169254418.wl@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1086789056 2581 80.91.224.253 (9 Jun 2004 13:50:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 9 Jun 2004 13:50:56 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jun 09 15:50:31 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BY3TK-00035I-00 for ; Wed, 09 Jun 2004 15:50:30 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BY3TK-0001r3-00 for ; Wed, 09 Jun 2004 15:50:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BY3Ty-0008AV-BF for emacs-devel@quimby.gnus.org; Wed, 09 Jun 2004 09:51:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BY3Tr-0008AG-Bv for emacs-devel@gnu.org; Wed, 09 Jun 2004 09:51:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BY3Tp-0008A4-Ey for emacs-devel@gnu.org; Wed, 09 Jun 2004 09:51:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BY3Tp-0008A1-Be for emacs-devel@gnu.org; Wed, 09 Jun 2004 09:51:01 -0400 Original-Received: from [212.227.126.188] (helo=moutng.kundenserver.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BY3So-00064B-L4 for emacs-devel@gnu.org; Wed, 09 Jun 2004 09:49:58 -0400 Original-Received: from [212.227.126.206] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BY3So-00022x-00 for emacs-devel@gnu.org; Wed, 09 Jun 2004 15:49:58 +0200 Original-Received: from [80.129.65.32] (helo=orion.univie.ac.at) by mrelayng.kundenserver.de with asmtp (TLSv1:EDH-RSA-DES-CBC3-SHA:168) (Exim 3.35 #1) id 1BY3Sn-0002Dm-00 for emacs-devel@gnu.org; Wed, 09 Jun 2004 15:49:58 +0200 Original-Received: from localhost (localhost [127.0.0.1]) by orion.univie.ac.at (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id i59Da7425775 for ; Wed, 9 Jun 2004 15:36:07 +0200 Original-To: emacs-devel@gnu.org X-Mailer: Mew version 4.0.65 on Emacs 21.3.50.1 / Mule 5.0 (SAKAKI) X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:2dc398bc694a1e60948148ba0a42c0da X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24770 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24770 [CVS 2004-05-30] Assume this: foo bar After calling comment-region I get this: ;; foo ;; bar (the actual comment prefix doesn't matter). The doc string of comment-region says this: Comment or uncomment each line in the region. ^^^^^^^^^ This is not how command-region currently works. I really would like to have this: ;; foo ;; ;; bar In case the current behaviour is intentional, please change the prefix arg to make the function work on all lines. Or even better, make comment-region work as advertised: . A normal call comments all lines of a region. . A call prefixed with C-u comments only non-empty lines. I strongly suggest to abandon the current behaviour of the C-u prefix (i.e., uncommenting a region), given that we have a separate `uncomment-region' function. Werner