Re: avoid duplicates in history

[Dan Nicolaescu <dann@ics.uci.edu>]

Juri Linkov <juri@jurta.org> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:

  > When you'll write the final patch, please don't forget to make this
  > option customizable by adding it to cus-start.el somewhere near
  > `history-length'.

Thanks, will do, I didn't know about that. 

  > And please consider the situation where your patch doesn't work.
  > There is the following condition in `read_minibuf':
  > 
  > 	      /* Don't duplicate the most recent entry in the history.  */
  > 	      && NILP (Fequal (histstring, Fcar (histval)))))
  > 
  > which prevents removing all duplicate elements from the history
  > with your patch.
  > 
  > This condition is redundant when `history-delete-duplicates' is t.

I believe this is fine, that condition just avoids adding consecutive
identical entries, there's no need to do anything when that condition
is false.