From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Noah Friedman Newsgroups: gmane.emacs.devel Subject: Re: Last change to process.c breaks fetching pop3 mail (gnus/pop3.el) Date: Thu, 03 Jun 2004 16:26:01 -0700 (PDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040603162601.832889.FMU25511@nutty-waffle-cone.splode.com> References: <20040530160908.436326.FMU25511@nutty-waffle-cone.splode.com> <20040531143416.431708.FMU25511@nutty-waffle-cone.splode.com> Reply-To: Noah Friedman NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1086305191 32676 80.91.224.253 (3 Jun 2004 23:26:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 3 Jun 2004 23:26:31 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jun 04 01:26:22 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BW1bK-0007k0-00 for ; Fri, 04 Jun 2004 01:26:22 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BW1bK-0007NP-00 for ; Fri, 04 Jun 2004 01:26:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BW1bg-0001YK-6b for emacs-devel@quimby.gnus.org; Thu, 03 Jun 2004 19:26:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BW1bY-0001Xk-Fa for emacs-devel@gnu.org; Thu, 03 Jun 2004 19:26:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BW1bX-0001X6-38 for emacs-devel@gnu.org; Thu, 03 Jun 2004 19:26:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BW1bX-0001X3-10 for emacs-devel@gnu.org; Thu, 03 Jun 2004 19:26:35 -0400 Original-Received: from [209.237.255.10] (helo=nutty-waffle-cone.splode.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1BW1b2-0000hh-7E; Thu, 03 Jun 2004 19:26:04 -0400 Original-Received: from nutty-waffle-cone.splode.com (localhost.splode.com [127.0.0.1]) by nutty-waffle-cone.splode.com (8.13.0.Beta2/8.13.0.Beta2) with ESMTP id i53NQ2F8001978; Thu, 3 Jun 2004 16:26:02 -0700 DomainKey-Signature: a=rsa-sha1; s=test001; d=splode.com; c=simple; q=; b=Y pjTiTFVrCmGmPVf2mD7D4/LjuSxnGPEbRGJq52jMcndDVgKEKW2b18CORuMN3Zw Original-Received: (from noah@localhost) by nutty-waffle-cone.splode.com (8.13.0.Beta2/8.12.8/Submit) id i53NQ2Qx001975; Thu, 3 Jun 2004 16:26:02 -0700 Original-To: rms@gnu.org, emacs-devel@gnu.org In-Reply-To: (no-spam@cua.dk , 04 Jun 2004 00:37:20 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24490 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24490 >To continue on this, what is the proper message to pass to the >sentinel if the connection was closed by remote peer (or broken). > >Current message "exited abnormally with code 256" isn't very good, >so perhaps we should change that as well (to what ...?) > >However existing code may rely on the current message, so maybe we >need to leave it as is? I did a web search just to see if there were any snippets of code which actually tested for this string. There weren't a lot, although it's possible that program sources don't often get indexed. None of the elisp files I have archived, including gnu-emacs-sources archives going back a few years, had any instances of that string literal. ERC was just about the only case I could find and that's one of two applications (the other being zenirc) that prompted me to investigate the sentinel problem in the first place. In fact there hasn't been much reason to examine that string because the process sentinel for network connections has never been called before in this case; only when the remote end closes the connection would it get called. This bug is very old--I can reproduce it in emacs 18.59. >> But "finished" is the wrong way to decribe delete-process. >> "deleted" would be more appropriate. > >Normally, you would use delete-process to close the connection. > >So in that aspect "closed" would be better than "deleted". "closed" seems ambiguous to me; either side could close a connection. But only the local side can delete it. I think changing the process status signal is the most reliable indicator of who requested the disconnection. In the meantime the reason string ought to be made more user-friendly though I don't have any good suggestions.