New Tramp version fails with ssh.

New Tramp version fails with ssh.

[Luc Teirlinck]

I do C-x C-f on a file using the "/ssh:..." type syntax.
Local machine GNU/Linux, remote machine Solaris2.8.
Result (from *Messages*):

tramp: Finding a suitable `ls' command
tramp: Checking remote `/bin/ls' command for `-n' option
tramp: Testing remote command `/bin/ls' for -n...okay
tramp-check-ls-commands: Invalid function: (macro . #[(variable value
&rest body) "

Then follows some byte code which apparently calls describe-function,
because that is what happens if I try to yank.  Then:

[variable body value if get (quote byte-obsolete-variable) quote progn
let] 6 ("/usr/local/share/emacs/21.3.50/lisp/net/tramp.elc"
. 226654)])

I have a Tramp debug buffer, but it does not seem to contain any more
information.  It ends with:

# Finding a suitable `ls' command
# Checking remote `/bin/ls' command for `-n' option
$ test -x /bin/ls 2>/dev/null; echo tramp_exit_status $? 
tramp_exit_status 0
# Testing remote command `/bin/ls' for -n...
$ /bin/ls -lnd / >/dev/null 2>/dev/null; echo tramp_exit_status $? 
tramp_exit_status 0
# Testing remote command `/bin/ls' for -n...okay

Re: New Tramp version fails with ssh.

[Luc Teirlinck]

Here is a backtrace:

Debugger entered--Lisp error: (invalid-function (macro . #[(variable
value &rest body) ".. byte-code... [variable body value if get (quote byte-obsolete-variable) quote progn let] 6 ("/usr/local/share/emacs/21.3.50/lisp/net/tramp.elc" . 226654)]))
  tramp-let-maybe(47 47 nil "/bin/ls")
  tramp-check-ls-commands(nil "ssh" nil "raven.dms.auburn.edu" "ls" ("/bin" "/usr/bin" "/usr/sbin" "/usr/local/bin" "/usr/ccs/bin" "/local/bin" "/local/freeware/bin" "/local/gnu/bin" "/usr/freeware/bin" "/usr/pkg/bin" "/usr/contrib/bin"))
  tramp-find-ls-command(nil "ssh" nil "raven.dms.auburn.edu")
  tramp-post-connection(nil "ssh" nil "raven.dms.auburn.edu")
  tramp-open-connection-rsh(nil "ssh" nil "raven.dms.auburn.edu")
  tramp-maybe-open-connection(nil "ssh" nil "raven.dms.auburn.edu")
  tramp-send-command(nil "ssh" nil "raven.dms.auburn.edu" "cd ~; pwd" t)
  tramp-handle-expand-file-name("/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  apply(tramp-handle-expand-file-name ("/ssh:raven.dms.auburn.edu:sequences.texi" nil))
  tramp-sh-file-name-handler(expand-file-name "/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  apply(tramp-sh-file-name-handler expand-file-name ("/ssh:raven.dms.auburn.edu:sequences.texi" nil))
  tramp-file-name-handler(expand-file-name "/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  expand-file-name("/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  apply(expand-file-name ("/ssh:raven.dms.auburn.edu:sequences.texi" nil))
  tramp-completion-run-real-handler(expand-file-name ("/ssh:raven.dms.auburn.edu:sequences.texi" nil))
  tramp-completion-handle-expand-file-name("/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  apply(tramp-completion-handle-expand-file-name ("/ssh:raven.dms.auburn.edu:sequences.texi" nil))
  tramp-completion-file-name-handler(expand-file-name "/ssh:raven.dms.auburn.edu:sequences.texi" nil)
  expand-file-name("/ssh:raven.dms.auburn.edu:sequences.texi")
  find-file-noselect("/ssh:raven.dms.auburn.edu:sequences.texi" nil nil t)
  find-file("/ssh:raven.dms.auburn.edu:sequences.texi" t)
  call-interactively(find-file)

Re: New Tramp version fails with ssh.

[Andreas Schwab]

Luc Teirlinck <teirllm@dms.auburn.edu> writes:

> Here is a backtrace:
>
> Debugger entered--Lisp error: (invalid-function (macro . #[(variable
> value &rest body) ".. byte-code... [variable body value if get (quote byte-obsolete-variable) quote progn let] 6 ("/usr/local/share/emacs/21.3.50/lisp/net/tramp.elc" . 226654)]))
>   tramp-let-maybe(47 47 nil "/bin/ls")

Here is a patch:

--- tramp.el.~1.44.~	2004-05-30 22:19:07.000000000 +0200
+++ tramp.el	2004-05-30 22:21:11.204987203 +0200
@@ -1885,6 +1885,16 @@ If VAR is nil, then we bind `v' to the s
 ;; To be activated for debugging containing this macro
 (def-edebug-spec with-parsed-tramp-file-name t)
 
+(defmacro tramp-let-maybe (variable value &rest body)
+  "Let-bind VARIABLE to VALUE in BODY, but only if VARIABLE is not obsolete.
+BODY is executed whether or not the variable is obsolete.
+The intent is to protect against `obsolete variable' warnings."
+  `(if (get 'byte-obsolete-variable ',variable)
+       (progn ,@body)
+     (let ((,variable ,value))
+       ,@body)))
+(put 'tramp-let-maybe 'lisp-indent-function 2)
+
 ;;; Config Manipulation Functions:
 
 (defun tramp-set-completion-function (method function-list)
@@ -6790,16 +6800,6 @@ exiting if process is running."
     (funcall (symbol-function 'process-kill-without-query)
 	     process flag)))
 
-(defmacro tramp-let-maybe (variable value &rest body)
-  "Let-bind VARIABLE to VALUE in BODY, but only if VARIABLE is not obsolete.
-BODY is executed whether or not the variable is obsolete.
-The intent is to protect against `obsolete variable' warnings."
-  `(if (get 'byte-obsolete-variable ',variable)
-       (progn ,@body)
-     (let ((,variable ,value))
-       ,@body)))
-(put 'tramp-let-maybe 'lisp-indent-function 2)
-
 
 ;; ------------------------------------------------------------ 
 ;; -- Kludges section -- 

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: New Tramp version fails with ssh.

[Kai Grossjohann]

Andreas Schwab <schwab@suse.de> writes:

> Luc Teirlinck <teirllm@dms.auburn.edu> writes:
>
>> Here is a backtrace:
>>
>> Debugger entered--Lisp error: (invalid-function (macro . #[(variable
>> value &rest body) ".. byte-code... [variable body value if get (quote byte-obsolete-variable) quote progn let] 6 ("/usr/local/share/emacs/21.3.50/lisp/net/tramp.elc" . 226654)]))
>>   tramp-let-maybe(47 47 nil "/bin/ls")
>
> Here is a patch:

Thanks, Andreas.  Committed.

Kai

Re: New Tramp version fails with ssh.

[Stefan Monnier]

> tramp-check-ls-commands: Invalid function: (macro . #[(variable value
> &rest body) "

This is the very clear evidence of a miscompiled file.
Either because the file has some missing `require' calls or because
of missing dependencies in lisp/Makefile.in.  If the latter we can't fix it
(at least I don't know how to) but a bootstrap will work around the
missing dependency.


        Stefan

Re: New Tramp version fails with ssh.

[Luc Teirlinck]

Stefan Monnier wrote:

   > tramp-check-ls-commands: Invalid function: (macro . #[(variable value
   > &rest body) "

   This is the very clear evidence of a miscompiled file.
   Either because the file has some missing `require' calls or because
   of missing dependencies in lisp/Makefile.in.  If the latter we can't fix it
   (at least I don't know how to) but a bootstrap will work around the
   missing dependency.

Actually running `make maintainer-clean', `./configure' and `make
bootstrap' was the very first thing I tried after getting the error.
It did not help.  However, I checked that Andreas' patch (now
committed), solves the problem.

Sincerely,

Luc.

Re: New Tramp version fails with ssh.

[Stefan Monnier]

>> tramp-check-ls-commands: Invalid function: (macro . #[(variable value
>> &rest body) "

>    This is the very clear evidence of a miscompiled file.

So much for the "very clear evidence".


        Stefan