From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: convert-standard-filename's doc Date: Fri, 28 May 2004 11:27:42 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040528092904.7532.JMBARRANQUERO@wke.es> References: <3099-Thu27May2004202140+0300-eliz@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1085739899 21457 80.91.224.253 (28 May 2004 10:24:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 28 May 2004 10:24:59 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 28 12:24:51 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTeXj-0002ox-00 for ; Fri, 28 May 2004 12:24:51 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTeXi-0003L1-00 for ; Fri, 28 May 2004 12:24:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BTeUD-0002KI-0N for emacs-devel@quimby.gnus.org; Fri, 28 May 2004 06:21:13 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BTdwg-0005ZY-Jl for emacs-devel@gnu.org; Fri, 28 May 2004 05:46:34 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BTdeS-0002eR-Sy for emacs-devel@gnu.org; Fri, 28 May 2004 05:28:20 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BTdeS-0002de-4y for emacs-devel@gnu.org; Fri, 28 May 2004 05:27:44 -0400 Original-Received: from [172.17.221.23] (jsredondo.wk.org [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id LSNJZQCX; Fri, 28 May 2004 11:27:33 +0200 Original-To: Stefan Monnier In-Reply-To: X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24073 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24073 On 27 May 2004 18:19:09 -0400 Stefan Monnier wrote: > So I think the "generic" text needs to be in, together with an explanation > of what this specific instance of convert-standard-filename does. Yes, I agree. What I objected to is the way it is now, because reading the docstring for a non-default version of the func it is non-obvious whether the function is "trivial" (does nothing) or not. > Basically I think that multiple definitions of the same function is > a bad thing. Yes!! On the "help argument highlighting" issue I finally added a function that the user must redefine to customize the arg highlighting. I did so per RMS' request, but I *hate* this way to customize. I would much prefer to have a hook. Every time I have to redefine a function to change some tiny think I'm afraid I'll accidentally miss fixes and enhancements to the original function. > Maybe using defadvice in dos-fns and w32-fns would be even > worse for various reasons, but I think that the docstrings should do > something similar to what we'd get if we used defadvice. Hmm... I'm not sure repeating all the original func's docstring is necessary. Better IMO something like: "Convert a standard file's name to something suitable for the current OS. The default definition just returns the argument. On Windows systems, however, this function - replaces invalid characters in FILENAME with ! - turns Cygwin-style /cygdrive/x/ pathnames into x:/ paths - converts slashes to backslashes Conversion of slashes only happens if the current shell expects it, as indicated by `w32-shell-dos-semantics'." Juanma