From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: Tramp with global-auto-revert-mode. Date: Fri, 14 May 2004 00:32:06 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200405140532.i4E5W6S15865@raven.dms.auburn.edu> References: <200405122254.i4CMsUj29445@raven.dms.auburn.edu> <200405122326.i4CNQk929511@raven.dms.auburn.edu> <200405132324.i4DNOBs14811@raven.dms.auburn.edu> <200405140008.i4E08lb14858@raven.dms.auburn.edu> <871xln4xmc.fsf-monnier+emacs@gnu.org> <200405140231.i4E2V9A15362@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1084512969 21030 80.91.224.253 (14 May 2004 05:36:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 14 May 2004 05:36:09 +0000 (UTC) Cc: kai@emptydomain.de, monnier@iro.umontreal.ca, storm@cua.dk, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 14 07:35:59 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BOVMV-0004VO-00 for ; Fri, 14 May 2004 07:35:59 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BOVMV-0003aZ-00 for ; Fri, 14 May 2004 07:35:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BOVJt-0002or-B6 for emacs-devel@quimby.gnus.org; Fri, 14 May 2004 01:33:17 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BOVJY-0002oY-VL for emacs-devel@gnu.org; Fri, 14 May 2004 01:32:57 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BOVJ2-0002ma-8W for emacs-devel@gnu.org; Fri, 14 May 2004 01:32:56 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BOVJ1-0002mT-Uh for emacs-devel@gnu.org; Fri, 14 May 2004 01:32:24 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i4E5WFTS001814; Fri, 14 May 2004 00:32:15 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i4E5W6S15865; Fri, 14 May 2004 00:32:06 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: teirllm@dms.auburn.edu In-reply-to: <200405140231.i4E2V9A15362@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 13 May 2004 21:31:09 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23383 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23383 My proposed patch had an obvious bug. Here is a corrected version, although we will probably need additional or different changes. ===File ~/auto-revert-diff================================== *** autorevert.el 04 Apr 2004 19:50:59 -0500 1.29 --- autorevert.el 14 May 2004 00:12:18 -0500 *************** *** 185,190 **** --- 185,199 ---- :group 'auto-revert :type 'boolean) + (defcustom global-auto-revert-remote-files nil + "When non-nil, Global Auto-Revert Mode reverts remote files. + Setting this non-nil can be dangerous. If you have a slow + connection, or are not permanently on-line, freezes and other + problems can result." + :group 'auto-revert + :type 'boolean + :version "21.4") + (defcustom global-auto-revert-ignore-modes '() "List of major modes Global Auto-Revert Mode should not check." :group 'auto-revert *************** *** 311,316 **** --- 320,328 ---- (unless (buffer-modified-p) (let ((buffer (current-buffer)) revert eob eoblist) (or (and buffer-file-name + (or (not (file-remote-p buffer-file-name)) + auto-revert-mode + global-auto-revert-remote-files) (file-readable-p buffer-file-name) (not (verify-visited-file-modtime buffer)) (setq revert t)) ============================================================