From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: workings and docstring of internal-lisp-face-equal-p Date: Thu, 13 May 2004 10:06:25 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040513095339.FB78.JMBARRANQUERO@wke.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1084436765 20306 80.91.224.253 (13 May 2004 08:26:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 13 May 2004 08:26:05 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu May 13 10:25:58 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BOBXS-0002Ot-00 for ; Thu, 13 May 2004 10:25:58 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BOBXR-0006Xo-00 for ; Thu, 13 May 2004 10:25:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BOBFD-0005O4-VB for emacs-devel@quimby.gnus.org; Thu, 13 May 2004 04:07:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BOBF5-0005Mb-NJ for emacs-devel@gnu.org; Thu, 13 May 2004 04:06:59 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BOBEY-0005GG-RB for emacs-devel@gnu.org; Thu, 13 May 2004 04:06:57 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BOBEY-0005G9-F1 for emacs-devel@gnu.org; Thu, 13 May 2004 04:06:26 -0400 Original-Received: from [172.17.221.23] (jsredondo.wk.org [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id K4TS1WCN; Thu, 13 May 2004 10:06:18 +0200 Original-To: emacs-devel@gnu.org X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23308 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23308 Documentation for internal-lisp-face-equal-p has this bit: If the optional argument FRAME is given, report on face FACE in that frame. If FRAME is t, report on the defaults for face FACE (for new frames). If FRAME is omitted or nil, use the selected frame. */) but the arguments are FACE1 and FACE2, not FACE. This seems like a c&p bug, because the docstring is almost identical to the one for `internal-lisp-face-empty-p'. The code is a bit weird. What is the frame_or_selected_frame call for, other than perhaps checking the passed frame wich CHECK_LIVE_FRAME? The resulting struct frame * f is not used, because the function is passing NULL to lface_from_face_name, so in fact what is doing is comparing the defaults of FACE1 and FACE2 for new frames... Juanma