From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: Buffer-local faces patch Date: Mon, 3 May 2004 15:14:35 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040503191435.GA21891@fencepost> References: <87y8o9oilp.fsf@tc-1-100.kawasaki.gol.ne.jp> <2914-Mon03May2004204357+0300-eliz@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1083612213 4178 80.91.224.253 (3 May 2004 19:23:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 May 2004 19:23:33 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 03 21:23:20 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKj28-00065z-00 for ; Mon, 03 May 2004 21:23:20 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKj28-0005ay-00 for ; Mon, 03 May 2004 21:23:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKj14-00010H-RM for emacs-devel@quimby.gnus.org; Mon, 03 May 2004 15:22:14 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BKivD-0005UZ-09 for emacs-devel@gnu.org; Mon, 03 May 2004 15:16:11 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BKiuX-0005EF-7e for emacs-devel@gnu.org; Mon, 03 May 2004 15:16:00 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKith-0004YK-M9 for emacs-devel@gnu.org; Mon, 03 May 2004 15:14:37 -0400 Original-Received: from miles by fencepost.gnu.org with local (Exim 4.24) id 1BKitf-0006m6-HG; Mon, 03 May 2004 15:14:35 -0400 Original-To: Eli Zaretskii Content-Disposition: inline In-Reply-To: <2914-Mon03May2004204357+0300-eliz@gnu.org> User-Agent: Mutt/1.3.28i Blat: Foop X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22644 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22644 On Mon, May 03, 2004 at 08:43:58PM +0200, Eli Zaretskii wrote: > I didn't yet try to use this, only read through the patch, so the > following question might be annoyingly stupid: I see DEFAULT_FACE_ID > being referenced in lots of the current source files besides the ones > you modified. Is this patch supposed to work on all types of displays > supported by Emacs, or just on X? I don't know. I didn't pay much attention to non-X stuff, but the changes outside of xfaces.c are very small and I think they're all in generic code, so it may just work. I tried to avoid changing all the uses of DEFAULT_FACE_ID because as you say there are lots of them. The cases where DEFAULT_FACE_ID need _not_ be changed are: (1) Where the face-id is passed (eventually) to init_iterator, as init_iterator will do the work (the face passed to init_iterator is not a `real' face-id anyway, it is required to be one of the basic face-ids). (2) Where the code really wants the underlying default face, not the buffer's default face. An example of this might be where it's going to test whether it can just draw the background color -- in this case you want to treat a remapped default-face as just another face (i.e., not the background). Those two exceptions cover many, many, uses. There are a few I'm not sure about, e.g., the fringe munging code, but the patch tends to fail conservatively, so the only effect might be that remapping doesn't take in some cases (like the fringe face). -Miles -- [|nurgle|] ddt- demonic? so quake will have an evil kinda setting? one that will make every christian in the world foamm at the mouth? [iddt] nurg, that's the goal