From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Pure strings (Re: Compilation to native) Date: Mon, 19 Apr 2004 15:36:00 +0900 (JST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200404190636.PAA29191@etlken.m17n.org> References: <87eks0654s.fsf@sno.mundell.ukfsn.org> <87n06bp4ng.fsf@sno.mundell.ukfsn.org> <8765cwkejr.fsf@mail.jurta.org> <200404071157.UAA25094@etlken.m17n.org> <87oepvo4jz.fsf@mail.jurta.org> <200404132340.IAA14502@etlken.m17n.org> <87u0zniciw.fsf@mail.jurta.org> <87fzb5h4x7.fsf_-_@mail.jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1082356810 31267 80.91.224.253 (19 Apr 2004 06:40:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 19 Apr 2004 06:40:10 +0000 (UTC) Cc: juri@jurta.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Apr 19 08:39:59 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BFSRj-0007kH-00 for ; Mon, 19 Apr 2004 08:39:59 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BFSRj-0007LN-00 for ; Mon, 19 Apr 2004 08:39:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFSRT-0001JC-7v for emacs-devel@quimby.gnus.org; Mon, 19 Apr 2004 02:39:43 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BFSQ2-0000ko-Qf for emacs-devel@gnu.org; Mon, 19 Apr 2004 02:38:14 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BFSPT-0000Bz-Mi for emacs-devel@gnu.org; Mon, 19 Apr 2004 02:38:10 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFSNw-0007JI-1X; Mon, 19 Apr 2004 02:36:04 -0400 Original-Received: from fs.m17n.org (fs.m17n.org [192.47.44.2]) by tsukuba.m17n.org (8.11.6p2/8.11.6) with ESMTP id i3J6a1815541; Mon, 19 Apr 2004 15:36:01 +0900 (JST) Original-Received: from etlken.m17n.org (etlken.m17n.org [192.47.44.125]) by fs.m17n.org (8.11.6p2/8.11.6) with ESMTP id i3J6a0926833; Mon, 19 Apr 2004 15:36:00 +0900 (JST) Original-Received: (from handa@localhost) by etlken.m17n.org (8.8.8+Sun/3.7W-2001040620) id PAA29191; Mon, 19 Apr 2004 15:36:00 +0900 (JST) Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Sun, 18 Apr 2004 17:47:12 -0400) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/21.3 (sparc-sun-solaris2.6) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21866 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21866 In article , Richard Stallman writes: > This error is raised on the string "Buffers" by the macro CHECK_IMPURE. > Could someone explain why should this string be "impure"? > The problem occurs because the string is pure. It looks like it > is pure because it comes from menu-bar-update-buffers, > which is in a preloaded file. > Does this patch fix it? Yes. Isn't it better to do copy-sequence on the fly, for instance, in parse_menu_item (in keyboard.c) to avoid the similar problem for the future? --- Ken'ichi HANDA handa@m17n.org