unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* cperl-mode
@ 2004-03-26 14:47 Stefan Monnier
  2004-03-26 18:03 ` cperl-mode Juanma Barranquero
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2004-03-26 14:47 UTC (permalink / raw)
  Cc: emacs-devel


What was the reason for the change below:

2004-03-25  Juanma Barranquero  <lektu@terra.es>

	* progmodes/cperl-mode.el (cperl-indent-alist, cperl-where-am-i):
	Comment out (it's unused and unfinished code).

I suggest we try and refrain from such changes because they make it more
difficult to merge in changes from the author in the future.


        Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cperl-mode
  2004-03-26 14:47 cperl-mode Stefan Monnier
@ 2004-03-26 18:03 ` Juanma Barranquero
  2004-03-26 18:29   ` cperl-mode Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Juanma Barranquero @ 2004-03-26 18:03 UTC (permalink / raw)
  Cc: Stefan Monnier

On 26 Mar 2004 09:47:49 -0500, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> What was the reason for the change below:

Well, is a bunch of complex, completely unused code and has been so for
a long time (at least two years), and it generates a warning.

> I suggest we try and refrain from such changes because they make it more
> difficult to merge in changes from the author in the future.

I know you've been merging Ilya's version about once a year (judging by
the ChangeLog). I didn't do the change lightly; I thought about it, and
in the end I concluded it wouldn't represent too much of a problem. I'll
revert the change if you feel I'm mistaken.

                                                           /L/e/k/t/u

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cperl-mode
  2004-03-26 18:03 ` cperl-mode Juanma Barranquero
@ 2004-03-26 18:29   ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2004-03-26 18:29 UTC (permalink / raw)
  Cc: emacs-devel

> I know you've been merging Ilya's version about once a year (judging by
> the ChangeLog). I didn't do the change lightly; I thought about it, and
> in the end I concluded it wouldn't represent too much of a problem.

Fair enough.

> I'll revert the change if you feel I'm mistaken.

Not worth the trouble,


        Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-03-26 18:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-26 14:47 cperl-mode Stefan Monnier
2004-03-26 18:03 ` cperl-mode Juanma Barranquero
2004-03-26 18:29   ` cperl-mode Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).