From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: Suggestion for autorevert.el Date: Wed, 24 Mar 2004 22:06:52 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200403250406.i2P46q711946@raven.dms.auburn.edu> References: <87zna6l1kn.fsf@offby1.atm01.sea.blarg.net> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1080188018 3427 80.91.224.253 (25 Mar 2004 04:13:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2004 04:13:38 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Mar 25 05:13:34 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B6MFK-0008Ph-00 for ; Thu, 25 Mar 2004 05:13:34 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B6MFJ-0003Ev-00 for ; Thu, 25 Mar 2004 05:13:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B6MBt-00070X-Ec for emacs-devel@quimby.gnus.org; Wed, 24 Mar 2004 23:10:01 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B6MBL-0006uX-Cv for emacs-devel@gnu.org; Wed, 24 Mar 2004 23:09:27 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B6MAo-0006pJ-Of for emacs-devel@gnu.org; Wed, 24 Mar 2004 23:09:25 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B6MAo-0006p9-DQ for emacs-devel@gnu.org; Wed, 24 Mar 2004 23:08:54 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i2P48kKt027473; Wed, 24 Mar 2004 22:08:46 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i2P46q711946; Wed, 24 Mar 2004 22:06:52 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: offby1@blarg.net In-reply-to: <87zna6l1kn.fsf@offby1.atm01.sea.blarg.net> (message from Eric Hanchrow on Wed, 24 Mar 2004 07:14:16 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20866 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20866 Eric Hanchrow wrote: You'll note I have a question: the new variable auto-revert-tail seems like it ought to be buffer-local, but it's not clear to me how to make it so if I use `defcustom'. I was tempted to use `defvar' instead, since a few other variables in autorevert.el are themselves defined with `defvar' ... but I'm not sure why. Your variable auto-revert-tail, in one form or another, seems to make sense. (`t' would definitely be the wrong default for certain non-file buffers, such as dired or the Buffer Menu.) If you use defcustom then setting the value with Custom will set the global default value. Since the behavior can be quite disruptive if it is non-intentional, also for file buffers, I do not believe that using this as a global default would be useful to many users. I personally would use defvar and make-variable-buffer-local. As such, I believe that it can be useful. But maybe there are better solutions than that. Variations are possible. Maybe if point _already_ is at the end of the buffer, then it stays there. That would seem to be more suitable for a global default and hence a defcustom. That one would not seem to get too disruptive too often. Sincerely, Luc.