From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: dapfy@t-online.de (Daniel Pfeiffer) Newsgroups: gmane.emacs.devel Subject: Re: new compile command doesn't coalesce errors on the same line Date: Sun, 21 Mar 2004 09:22:24 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040321092224.039cd09b.occitan@esperanto.org> References: <20040317215208.5b0cb3e2.occitan@esperanto.org> <20040317224726.GC12561@fencepost> <20040320074137.2ea2c886.occitan@esperanto.org> Reply-To: Daniel Pfeiffer NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1079858537 6525 80.91.224.253 (21 Mar 2004 08:42:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 21 Mar 2004 08:42:17 +0000 (UTC) Cc: miles@lsi.nec.co.jp, emacs-devel@gnu.org, monnier@iro.umontreal.ca, miles@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Mar 21 09:42:10 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B4yX4-0005j9-00 for ; Sun, 21 Mar 2004 09:42:10 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B4yX4-0003wL-00 for ; Sun, 21 Mar 2004 09:42:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B4yND-0004CL-Cz for emacs-devel@quimby.gnus.org; Sun, 21 Mar 2004 03:31:59 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B4yMw-00046l-VH for emacs-devel@gnu.org; Sun, 21 Mar 2004 03:31:42 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B4yMU-0003y6-UH for emacs-devel@gnu.org; Sun, 21 Mar 2004 03:31:41 -0500 Original-Received: from [194.25.134.19] (helo=mailout06.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B4yEC-0002ZF-3t; Sun, 21 Mar 2004 03:22:40 -0500 Original-Received: from fwd06.aul.t-online.de by mailout06.sul.t-online.com with smtp id 1B4yE6-0006OQ-05; Sun, 21 Mar 2004 09:22:34 +0100 Original-Received: from pfdabpc.inhouse.start.de (TFNxFkZ-oeSN8Iw-ueC-pOIc8E1GaDTHRRJ+QPr+3IQ2LnbO8Mj84t@[217.234.53.34]) by fwd06.sul.t-online.com with smtp id 1B4yE0-20vhce0; Sun, 21 Mar 2004 09:22:28 +0100 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Sylpheed version 0.9.4claws (GTK+ 1.2.10; i686-suse-linux) X-Seen: false X-ID: TFNxFkZ-oeSN8Iw-ueC-pOIc8E1GaDTHRRJ+QPr+3IQ2LnbO8Mj84t X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20677 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20677 Saluton, Moin, Richard Stallman skribis: > Are we talking about the same docstring? I (having written it :-) find > it quite clear: > > "*Compilation motion commands skip visited messages if this is t. > Visited messages are ones for which the file, line and column have been > jumped to from the current content in the current compilation buffer, > even if it was from a different message." > > Yes, that is the docstring I can't understand. Is this better? *Compilation motion commands skip visited locations if this is t. A location is considered visited if you've already jumped there. It doesn't matter if this happened from a different message. After you start a new compilation, all locations will again be initially considered unvisited. > > Meanwhile, to the extent I can figure it out, I think this is indeed > > something else. Let's just change the code so as to treat > > contiguous errors as one. > > How contiguous do they have to be? > > I'd suggest that if one error and the next error point to the same > location then they are contiguous. The example I cited location a: ... location b location a: more bla about a is not contrived. I've seen this frequently at work. The old compile simply ignored location b. Now it is found and breaks immediate contiguousness. > What would we gain? Why would I want to go to the same spot again if it > is mentioned 3 lines down, but not when it is mentioned on the next > line? > > The point is to do the convenient thing in a simple common case of > multiple errors from a single line. What happens in the strange cases > is less important because they are rare. So you may as well handle > them in whatever way seems most correct. Well, the most convenient (also for messages in headers, which get rereported 1000 times) would be to set compilation-skip-visited to t, like a few people requested. This would automatically cover the case of contiguous messages, without the hassle of searching for same locations in the vicinity. Does my suggested new documentation make this more appealing? But if we get a few votes for a necessity to skip-same-near-messages "yes", skip-same-far-messages "no" it wouldn't be impossible to implement. In that case the documentation would become: *Compilation motion commands skip visited locations if this is non-nil. A location is considered visited if you've already jumped there. It doesn't matter if this happened from a different message. If this is t, you will not go to the same location again. If this is a number, that only applies if the visited location is mentioned in that many preceding (following when moving backwards) lines. After you start a new compilation, all locations will again be initially considered unvisited. coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn Daniel Pfeiffer -- lerne / learn / apprends / läramå / ucz się Esperanto: http://lernu.net/