broken input mechanism

broken input mechanism

[Tak Ota]

The current keyboard.c is broken on W32 platform.  When key input
accumulates substantially (auto repeating key faster than redisplay)
Emacs crashes variety of way.  On the latest revision 1.766 it always
crashes in get_filtered_input_pending where addr holding bogus value
(mostly 0x04000000, rarely 0x00000000).  Strangely the call stack
only shows get_filtered_input_pending and get_input_pending but
nothing before under VC++ debugger.

Revision must go back to 1.761 to have a good build without this
problem.

Re: broken input mechanism

[Kim F. Storm]

Tak Ota <Takaaki.Ota@am.sony.com> writes:

> The current keyboard.c is broken on W32 platform.  When key input
> accumulates substantially (auto repeating key faster than redisplay)
> Emacs crashes variety of way.  On the latest revision 1.766 it always
> crashes in get_filtered_input_pending where addr holding bogus value
> (mostly 0x04000000, rarely 0x00000000).  Strangely the call stack
> only shows get_filtered_input_pending and get_input_pending but
> nothing before under VC++ debugger.
> 
> Revision must go back to 1.761 to have a good build without this
> problem.

Does the following patch fix this?

Index: w32term.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
retrieving revision 1.206
diff -c -r1.206 w32term.c
*** w32term.c	22 Feb 2004 22:41:52 -0000	1.206
--- w32term.c	24 Feb 2004 20:09:24 -0000
***************
*** 4168,4174 ****
  
    /* TODO: tool-bars, ghostscript integration, mouse
       cursors. */
!   while (get_next_msg (&msg, FALSE))
      {
        switch (msg.msg.message)
  	{
--- 4168,4174 ----
  
    /* TODO: tool-bars, ghostscript integration, mouse
       cursors. */
!   while (numchars > 0 && get_next_msg (&msg, FALSE))
      {
        switch (msg.msg.message)
  	{

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: broken input mechanism

[Tak Ota]

Yes, it indeed has fixed the problem.  Thanks Kim.

-Tak

24 Feb 2004 22:10:50 +0100: storm@cua.dk (Kim F. Storm) wrote:

> Tak Ota <Takaaki.Ota@am.sony.com> writes:
> 
> > The current keyboard.c is broken on W32 platform.  When key input
> > accumulates substantially (auto repeating key faster than redisplay)
> > Emacs crashes variety of way.  On the latest revision 1.766 it always
> > crashes in get_filtered_input_pending where addr holding bogus value
> > (mostly 0x04000000, rarely 0x00000000).  Strangely the call stack
> > only shows get_filtered_input_pending and get_input_pending but
> > nothing before under VC++ debugger.
> > 
> > Revision must go back to 1.761 to have a good build without this
> > problem.
> 
> Does the following patch fix this?
> 
> Index: w32term.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
> retrieving revision 1.206
> diff -c -r1.206 w32term.c
> *** w32term.c	22 Feb 2004 22:41:52 -0000	1.206
> --- w32term.c	24 Feb 2004 20:09:24 -0000
> ***************
> *** 4168,4174 ****
>   
>     /* TODO: tool-bars, ghostscript integration, mouse
>        cursors. */
> !   while (get_next_msg (&msg, FALSE))
>       {
>         switch (msg.msg.message)
>   	{
> --- 4168,4174 ----
>   
>     /* TODO: tool-bars, ghostscript integration, mouse
>        cursors. */
> !   while (numchars > 0 && get_next_msg (&msg, FALSE))
>       {
>         switch (msg.msg.message)
>   	{
> 
> -- 
> Kim F. Storm <storm@cua.dk> http://www.cua.dk
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel