unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ehud Karni" <ehud@unix.mvs.co.il>
Cc: jari.aalto@poboxes.com
Subject: Re: Emacs 21.3.50 grep.el/executable.el problems
Date: Sun, 15 Feb 2004 13:43:09 +0200	[thread overview]
Message-ID: <200402151143.i1FBh9pU011407@beta.mvs.co.il> (raw)
In-Reply-To: <200402141504.i1EF4gGP000494@beta.mvs.co.il> (message from Ehud Karni on Sat, 14 Feb 2004 17:04:42 +0200)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 14 Feb 2004 17:04:42 +0200, Ehud Karni <ehud@unix.mvs.co.il> wrote:
>
> 2. progmodes/executable.el calls `find-if' which is defined in
>    cl-seq.el and requires the cl.el .

Actually `executable-command-find-posix-p' does not work well if
(car load-path) is a symbolic link name (and because of this it
failed for me on both GNU\Linux and Cygwin - both posix systems).


The following patch will fix this.

Ehud.


cd /lnx1/gnu/src/emacs/lisp/progmodes/
diff -c /lnx1/gnu/src/emacs/lisp/progmodes/executable.el.\~1.30.\~ /lnx1/gnu/src/emacs/lisp/progmodes/executable.el
*** /lnx1/gnu/src/emacs/lisp/progmodes/executable.el.~1.30.~	Wed Feb  4 14:33:38 2004
- --- /lnx1/gnu/src/emacs/lisp/progmodes/executable.el	Sun Feb 15 13:30:16 2004
***************
*** 146,156 ****
  If PROGRAM is non-nil, use that instead of \"find\"."
    ;;  Pick file to search from location we know
    (let* ((dir   (car load-path))
!          (file  (find-if
!                  (lambda (x)
!                    ;; Filter directories . and ..
!                    (not (string-match "^\\.\\.?$" x)))
!                  (directory-files dir))))
      (with-temp-buffer
        (call-process (or program "find")
                      nil
- --- 146,159 ----
  If PROGRAM is non-nil, use that instead of \"find\"."
    ;;  Pick file to search from location we know
!   (let* ((dir (car load-path))
!          files file)
!     (setq dir (or (file-symlink-p dir) dir))
!     (setq files (directory-files dir))
!     (while files
!        (setq file (car files))
!        (if (string-match "^\\.\\.?$" file)
!            (setq files (cdr files))
!            (setq files nil)))
      (with-temp-buffer
        (call-process (or program "find")
                      nil

Diff finished at Sun Feb 15 13:31:55


- --
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)

iD8DBQFAL1tMLFvTvpjqOY0RAht0AJ4lZJjOoIAId6hhMpZytAVpKwwo8gCfYiEM
XMCxSdqTvy+vKutl/KMMM+4=
=giEk
-----END PGP SIGNATURE-----

  reply	other threads:[~2004-02-15 11:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-13  6:32 Emacs 21.3.50 on cygwin bootstrap failed. (Jason Rumney) Steven Wu
2004-02-14 15:04 ` Emacs 21.3.50 grep.el/executable.el problems Ehud Karni
2004-02-15 11:43   ` Ehud Karni [this message]
2004-02-15 12:59     ` Piet van Oostrum
2004-02-15 13:20   ` Thien-Thi Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2004-02-16 14:35 Markus Rost
2004-02-16 15:17 ` Ehud Karni
2004-02-16 16:14 ` Stefan Monnier
2004-02-16 19:57   ` Eli Zaretskii
2004-02-16 20:16     ` Stefan Monnier
2004-02-16 20:31       ` Jason Rumney
2004-02-16 21:10     ` Markus Rost
2004-02-17  6:34       ` Eli Zaretskii
2004-02-18  8:39       ` Richard Stallman
2004-02-18 20:55         ` Markus Rost
2004-02-17 17:27   ` Richard Stallman
2004-02-16 16:30 ` Kim F. Storm
2004-02-16 16:23   ` Markus Rost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402151143.i1FBh9pU011407@beta.mvs.co.il \
    --to=ehud@unix.mvs.co.il \
    --cc=jari.aalto@poboxes.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).