unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: schwab@suse.de, emacs-devel@gnu.org
Subject: Re: Fixed bug in completing-read
Date: Thu, 25 Dec 2003 12:53:24 -0600 (CST)	[thread overview]
Message-ID: <200312251853.hBPIrOq15822@raven.dms.auburn.edu> (raw)
In-Reply-To: <E1AZXUE-0004lc-MK@fencepost.gnu.org> (message from Richard Stallman on Thu, 25 Dec 2003 10:33:18 -0500)

Richard Stallman wrote:

   Since this is a rather obscure feature, not used in too many places,
   we should make the decision based on what is clean, not based on
   compatibility with this or that.  Since these positions go with
   strings, they should be zero-origin.

I have reverted my changes in `Fcompleting_read', as well as the
related change in ffap.el.  The entire treatment of conses as values
for INITIAL is back to where it was before my changes, except that a
few more functions can handle such values.

I do not know whether your remark above only applies to
`completing-read' (in which case it is completely taken care of) or
also to `read-from-minibuffer' and friends.  In the latter case, I
would have only one single objection, but a big one.  That is the
amount of work involved in adapting existing code.  The feature is
used more often than you seem to believe.  I already had my
reservations about changing things the other way around, but this way
things are a _lot_ worse.  (I took a look at it.)

The very existence of INITIAL is unclean (it competes with DEFAULT and
provides an inconsistent user interface) and it only exists for
historical compatibility.  Hence, I propose to just document the
inconsistency and say that the entire argument, inconsistencies and
all, only exists for historical compatibility anyway.  Just one more
reason to use DEFAULT instead.

A semi-obsolete argument is not worth tons of work.  Existing code
seems to use the argument based on the inconsistency, so no problem
there.  New code should not use it, so no problem there either.

Sincerely,

Luc.

  reply	other threads:[~2003-12-25 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-24 17:29 Fixed bug in completing-read Andreas Schwab
2003-12-24 20:03 ` Luc Teirlinck
2003-12-25 15:33   ` Richard Stallman
2003-12-25 18:53     ` Luc Teirlinck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-12-18  3:25 Bug " Luc Teirlinck
2003-12-24  3:18 ` Fixed bug " Luc Teirlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200312251853.hBPIrOq15822@raven.dms.auburn.edu \
    --to=teirllm@dms.auburn.edu \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).