From: Luc Teirlinck <teirllm@dms.auburn.edu>
Subject: Bug in completing-read
Date: Wed, 17 Dec 2003 21:25:28 -0600 (CST) [thread overview]
Message-ID: <200312180325.hBI3PSm02368@raven.dms.auburn.edu> (raw)
If one evaluates:
(read-from-minibuffer "Input: " '("123456789" . 3))
point appears on the "3" in the minibuffer.
But if one evaluates:
(completing-read "Input: " '("123456789") nil nil '("123456789" . 3))
point appears on the "4" in the minibuffer.
This is inconsistent and it also contradicts the documentation string
of `completing-read'. In other words, the behavior of
`completing-read' is an obvious bug. It is trivial to fix, in fact I
"inadvertently" fixed it in my own private Emacs.
In another thread ("read-from-minibuffer and friends"), I proposed a
patch that will move the handling of string-integer conses of the type
used above from Fread_from_minibuffer into read_minibuf. (Not yet
installed because of the Savannah situation.) After proposing that
patch I made some small further changes. (I got rid of variables that
were no longer used, but which I inadvertently forgot to remove.) But
then I noticed nearly identical code in Fcompleting_read. I removed
this now redundant code. But while diffing I noticed that a "-1" was
missing in a formula in the removed code. At first sight, wonderful.
Code gone, bug gone, end of story. Now the problem.
People using such arguments to `completing-read' apparently found it
easier to just get around the bug by putting the "-1" in their own
code, rather than reporting it or fixing it in minibuf.c.
So now we are left with the following choice:
1. Document this inconsistency in the documentation string of
`completing-read', as well as in the Elisp manual, and say that it
exists for historical compatibility. (I could do that, if that is
what we decide to do.)
2. Fix the bug and also fix existing code that relies on the bug. (I
could trivially fix the bug, if that is what we decide to do. As
mentioned above, I have already fixed it in my personal Emacs.
Finding _all_ code relying on the bug seems very non-trivial,
however, because `completing-read' is used so often.)
Example:
M-x load-library RET ffap
M-: (ffap-read-file-or-url "Input: " "myfile") RET
Result:
Input: ~/emacscvsdir/emacs/lisp/myfile
with point on the `m' of myfile, as probably intended. Fixing the bug
in `completing-read' would put it on the last `/'.
So do we fix this bug or make the inconsistency an "official, but
deprecated, feature" by documenting it?
Sincerely,
Luc.
next reply other threads:[~2003-12-18 3:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-18 3:25 Luc Teirlinck [this message]
2003-12-24 3:18 ` Fixed bug in completing-read Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312180325.hBI3PSm02368@raven.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).