From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: FIX#3: byte-code: Wrong type argument: number-or-marker-p, (+ -21) Date: Sun, 23 Nov 2003 22:32:37 +0100 (CET) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200311232226.hANMPvFY010668@stubby.bodenonline.com> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1069623291 14416 80.91.224.253 (23 Nov 2003 21:34:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 23 Nov 2003 21:34:51 +0000 (UTC) Cc: emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Nov 23 22:34:48 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AO1sW-0001N8-00 for ; Sun, 23 Nov 2003 22:34:48 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AO1sW-0005NO-00 for ; Sun, 23 Nov 2003 22:34:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AO2pL-0007nG-OM for emacs-devel@quimby.gnus.org; Sun, 23 Nov 2003 17:35:35 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AO2p7-0007l8-WA for emacs-devel@gnu.org; Sun, 23 Nov 2003 17:35:21 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AO2oa-0007U2-Hv for emacs-devel@gnu.org; Sun, 23 Nov 2003 17:35:19 -0500 Original-Received: from [193.201.16.94] (helo=stubby.bodenonline.com) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AO2oZ-0007KY-3l; Sun, 23 Nov 2003 17:34:47 -0500 Original-Received: from accessno42.bodenonline.com (IDENT:root@accessno42.bodenonline.com [193.201.16.44]) by stubby.bodenonline.com (8.12.1/8.12.1) with ESMTP id hANMPvFY010668; Sun, 23 Nov 2003 23:26:03 +0100 In-Reply-To: "from Jan Nieuwenhuizen at Nov 20, 2003 10:59:40 am" Original-To: Jan Nieuwenhuizen X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:18060 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:18060 > storm@cua.dk (Kim F. Storm) writes: > > >> but I'm not at all sure about the right arithmetic for (+/- INT) ... > > > > Me neither... What do others think about this? > > So here's a patch #3 to try. > This is tricky, the patch is quite good, but not entirely correct. % emacs -g 80x100+0-0 and % emacs -g 80x100-0-0 should align vertically and only differ horizontally, but they don't. Jan D. > Jan. > > 2003-11-20 Jan Nieuwenhuizen > > * frame.el (frame-notice-user-settings): Fix for TOP parameter > of CONS flavour. > > --- frame.el.~1.205.~ 2003-10-02 16:06:45.000000000 +0200 > +++ frame.el 2003-11-20 01:51:14.000000000 +0100 > @@ -335,10 +335,18 @@ React to settings of `default-frame-alis > frame-initial-geometry-arguments))) > (top (frame-parameter frame-initial-frame 'top))) > (when (and (consp initial-top) (eq '- (car initial-top))) > - (setq newparms > - (append newparms > - `((top . ,(+ top (* lines char-height)))) > - nil))) > + (let ((new-top > + (if (consp top) > + (cond ((eq '+ (car top)) > + (list > + '+ (+ (cadr top) (* lines char-height)))) > + ((eq '- (car top)) > + (list > + '- (- (display-pixel-height) > + ((cadr top) (* lines char-height))))) > + (t 0)) > + (+ top (* lines char-height))))) > + (setq newparms (append newparms `((top . ,new-top)) nil)))) > (modify-frame-parameters frame-initial-frame newparms) > (tool-bar-mode -1))))) > > > -- > Jan Nieuwenhuizen | GNU LilyPond - The music typesetter > http://www.xs4all.nl/~jantien | http://www.lilypond.org > > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://mail.gnu.org/mailman/listinfo/emacs-devel