From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: doc strings of reverse and nreverse. Date: Wed, 19 Nov 2003 22:29:25 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200311200429.hAK4TPj07755@raven.dms.auburn.edu> References: <200311200410.hAK4Axt07727@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1069303384 20834 80.91.224.253 (20 Nov 2003 04:43:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2003 04:43:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Nov 20 05:43:01 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMgej-0001PR-00 for ; Thu, 20 Nov 2003 05:43:01 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMgej-0007xf-00 for ; Thu, 20 Nov 2003 05:43:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMhVW-0000ls-1u for emacs-devel@quimby.gnus.org; Thu, 20 Nov 2003 00:37:34 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AMhVF-0000jX-Sx for emacs-devel@gnu.org; Thu, 20 Nov 2003 00:37:17 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AMhUj-0000JB-9j for emacs-devel@gnu.org; Thu, 20 Nov 2003 00:37:16 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMhUh-0000HX-HM for emacs-devel@gnu.org; Thu, 20 Nov 2003 00:36:43 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id hAK4ZIKk029659; Wed, 19 Nov 2003 22:35:18 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id hAK4TPj07755; Wed, 19 Nov 2003 22:29:25 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: teirllm@dms.auburn.edu In-reply-to: <200311200410.hAK4Axt07727@raven.dms.auburn.edu> (message from Luc Teirlinck on Wed, 19 Nov 2003 22:10:59 -0600 (CST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17941 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17941 I took a look at the C code of Freverse and Fnreverse and they do indeed always return the entire reversed list (except when they throw an error, of course). So why those confusing doc strings? The following would get rid of them. I could commit if desired. ===File ~/fns-diff========================================== cd ~/emacscvsdir/emacs/src/ diff -c /home/teirllm/fns.old.c /home/teirllm/emacscvsdir/emacs/src/fns.c *** /home/teirllm/fns.old.c Mon Nov 17 21:24:17 2003 --- /home/teirllm/emacscvsdir/emacs/src/fns.c Wed Nov 19 22:22:57 2003 *************** *** 1840,1846 **** DEFUN ("nreverse", Fnreverse, Snreverse, 1, 1, 0, doc: /* Reverse LIST by modifying cdr pointers. ! Returns the beginning of the reversed list. */) (list) Lisp_Object list; { --- 1840,1846 ---- DEFUN ("nreverse", Fnreverse, Snreverse, 1, 1, 0, doc: /* Reverse LIST by modifying cdr pointers. ! Return the reversed list. */) (list) Lisp_Object list; { *************** *** 1863,1869 **** } DEFUN ("reverse", Freverse, Sreverse, 1, 1, 0, ! doc: /* Reverse LIST, copying. Returns the beginning of the reversed list. See also the function `nreverse', which is used more often. */) (list) Lisp_Object list; --- 1863,1869 ---- } DEFUN ("reverse", Freverse, Sreverse, 1, 1, 0, ! doc: /* Reverse LIST, copying. Return the reversed list. See also the function `nreverse', which is used more often. */) (list) Lisp_Object list; Diff finished at Wed Nov 19 22:23:49 ============================================================