From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: :format strings in Custom ending in %h Date: Mon, 20 Oct 2003 13:05:25 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200310201805.h9KI5Pm09318@raven.dms.auburn.edu> References: <200308210154.h7L1sJc21082@raven.dms.auburn.edu> <200308212100.h7LL0d125524@raven.dms.auburn.edu> <200308221441.h7MEfoT27405@raven.dms.auburn.edu> <200308241717.h7OHHSu03863@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1066673800 16953 80.91.224.253 (20 Oct 2003 18:16:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Oct 2003 18:16:40 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Oct 20 20:16:37 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ABea5-0004tU-00 for ; Mon, 20 Oct 2003 20:16:37 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ABea5-0002k9-00 for ; Mon, 20 Oct 2003 20:16:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ABeVy-00042t-DX for emacs-devel@quimby.gnus.org; Mon, 20 Oct 2003 14:12:22 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ABeUL-0003Mr-Hf for emacs-devel@gnu.org; Mon, 20 Oct 2003 14:10:41 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ABeTm-0003CL-Vh for emacs-devel@gnu.org; Mon, 20 Oct 2003 14:10:39 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ABeTm-0003C7-9l for emacs-devel@gnu.org; Mon, 20 Oct 2003 14:10:06 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id h9KIA2Kk009201; Mon, 20 Oct 2003 13:10:03 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id h9KI5Pm09318; Mon, 20 Oct 2003 13:05:25 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: abraham@dina.kvl.dk In-reply-to: (message from Per Abrahamsen on Sun, 24 Aug 2003 20:30:05 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17268 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17268 I am about ready to submit a file for inclusion in Emacs. It contains a complex defcustom which does not function properly without the following patch. I have applied this patch to my own Emacs CVS and have used it ever since the end of August without problems. The patch is needed to fix an annoying problem in Custom which we discussed at the end of August. I had the impression that you were going to commit something along these lines: 2003-08-24 Per Abrahamsen * wid-edit.el (widget-default-delete): Always delete child widgets. *** wid-edit.el.~1.120.~ Thu Aug 21 14:17:37 2003 --- wid-edit.el Sun Aug 24 17:37:04 2003 *************** *** 1465,1470 **** --- 1465,1471 ---- (inhibit-modification-hooks t) (inhibit-read-only t)) (widget-apply widget :value-delete) + (widget-children-value-delete widget) (when inactive-overlay (delete-overlay inactive-overlay)) (when button-overlay Old follow-up message (from Per Abrahamsen): Luc Teirlinck writes: > I guess that after applying this patch > `widget-children-value-delete' > will become a pretty redundant value for :value-delete, essentially > equivalent with `ignore'. Yes, if we apply this patch we probably also should change all these values, mark widget-children-value-delete as obsolete (and inline the code in widget-default-delete), and document this property of :buttons and :children somewhere. But I don't know if there is some code that depend on :buttons and :children *not* being deleted recursively. Maybe applying the patch will be the easiest way to find out. Oh, and we probably should find other places where :buttons and :children are deleted (now) reduntantly, and adjust those. Did you change your mind about the next to last paragraph? >>From diffing with the current CVS, I noticed that the actual complete patch I have been using since August (and hence has been tested for a while) is the diff below. I believe your patch above (included in the one below) makes the second (earlier) change redundant however. I just forgot to remove it after applying your patch above. d ~/ diff -c /home/teirllm/emacscvsdir/emacs/lisp/wid-edit.el ;; (current CVS) /home/teirllm/wid-edit.el ;; personal, used since end August. *** /home/teirllm/emacscvsdir/emacs/lisp/wid-edit.el Mon Oct 20 11:00:20 2003 --- /home/teirllm/wid-edit.el Tue Sep 2 07:38:18 2003 *************** *** 1465,1470 **** --- 1465,1471 ---- (inhibit-modification-hooks t) (inhibit-read-only t)) (widget-apply widget :value-delete) + (widget-children-value-delete widget) (when inactive-overlay (delete-overlay inactive-overlay)) (when button-overlay *************** *** 1556,1562 **** "Constant items for inclusion in other widgets." :convert-widget 'widget-value-convert-widget :value-create 'widget-item-value-create ! :value-delete 'ignore :value-get 'widget-value-value-get :match 'widget-item-match :match-inline 'widget-item-match-inline --- 1557,1563 ---- "Constant items for inclusion in other widgets." :convert-widget 'widget-value-convert-widget :value-create 'widget-item-value-create ! :value-delete 'widget-children-value-delete :value-get 'widget-value-value-get :match 'widget-item-match :match-inline 'widget-item-match-inline Diff finished at Mon Oct 20 11:05:58