From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Tak Ota Newsgroups: gmane.emacs.devel Subject: etags segfault Date: Mon, 25 Aug 2003 18:18:41 -0700 (PDT) Organization: Sony Electronics Inc. Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20030825.181841.34002817.Takaaki.Ota@am.sony.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1061867184 20791 80.91.224.253 (26 Aug 2003 03:06:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 26 Aug 2003 03:06:24 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Aug 26 05:06:22 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19rUA2-0003Me-00 for ; Tue, 26 Aug 2003 05:06:22 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19rUFq-0007TU-00 for ; Tue, 26 Aug 2003 05:12:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19rU8p-0008Ev-2f for emacs-devel@quimby.gnus.org; Mon, 25 Aug 2003 23:05:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19rSem-0008DA-Tc for emacs-devel@gnu.org; Mon, 25 Aug 2003 21:30:00 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19rScW-0005tT-Pf for emacs-devel@gnu.org; Mon, 25 Aug 2003 21:28:13 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19rSZs-0004KC-18 for emacs-devel@gnu.org; Mon, 25 Aug 2003 21:24:56 -0400 Original-Received: from [160.33.98.73] (helo=mail6.fw-bc.sony.com) by mx20.gnu.org with esmtp (Exim 4.20) id 19rSUo-0001LD-RF for emacs-devel@gnu.org; Mon, 25 Aug 2003 21:19:42 -0400 Original-Received: from mail2.sjc.in.sel.sony.com (mail2.sjc.in.sel.sony.com [43.134.1.111]) by mail6.fw-bc.sony.com (8.8.8/8.8.8) with ESMTP id BAA29540 for ; Tue, 26 Aug 2003 01:18:42 GMT Original-Received: by mail2.sjc.in.sel.sony.com id BAA04121; Tue, 26 Aug 2003 01:18:42 GMT Original-To: emacs-devel@gnu.org X-Telephone: +1-858-942-3239 X-Fax------: +1-858-942-9142 X-SnailMail: 16450 West Bernardo Drive MZ7205, San Diego, CA 92127-1804 X-Mailer: Mew-4.0.58 on Emacs-21.3.50.1 (i386-msvc-nt5.0.2195) of 2003-08-22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:16152 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16152 Without the following patch etags causes a segmentation fault. -Tak ota@tak-4100 /cygdrive/d/pub/emacs/emacs-21.3.50/lib-src $ diff -c ../../pure/emacs-21.3.50/lib-src/etags.c etags.c *** ../../pure/emacs-21.3.50/lib-src/etags.c Tue Jul 29 07:39:03 2003 --- etags.c Mon Aug 25 18:02:34 2003 *************** *** 3116,3122 **** fvdef = vignore; return FALSE; } ! if (strneq (str+len-10, "::operator", 10)) { if (*c_extp & C_AUTO) /* automatic detection of C++ */ *c_extp = (*c_extp | C_PLPL) & ~C_AUTO; --- 3116,3122 ---- fvdef = vignore; return FALSE; } ! if (len-10 > 0 && strneq (str+len-10, "::operator", 10)) { if (*c_extp & C_AUTO) /* automatic detection of C++ */ *c_extp = (*c_extp | C_PLPL) & ~C_AUTO; ota@tak-4100 /cygdrive/d/pub/emacs/emacs-21.3.50/lib-src $ diff -c ../../pure/emacs-21.3.50/lib-src/ChangeLog ChangeLog *** ../../pure/emacs-21.3.50/lib-src/ChangeLog Fri Aug 22 06:37:32 2003 --- ChangeLog Mon Aug 25 18:15:05 2003 *************** *** 1,3 **** --- 1,8 ---- + 2003-08-25 Takaaki Ota + + * etags.c (consider_token): check C++ `operator' only when the + token len is long enough. + 2003-08-20 Dave Love * Makefile.in: Remove obsolete references to alloca.