From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: font lock in gdb-script mode Date: Wed, 23 Jul 2003 09:32:39 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200307231332.h6NDWdRs030126@rum.cs.yale.edu> References: <20030723.221818.47712410.jet@gyve.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1058967360 17264 80.91.224.249 (23 Jul 2003 13:36:00 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2003 13:36:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jul 23 15:35:59 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19fJmh-0004UI-00 for ; Wed, 23 Jul 2003 15:35:59 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19fK4L-00084i-00 for ; Wed, 23 Jul 2003 15:54:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19fJkS-0002dY-Q8 for emacs-devel@quimby.gnus.org; Wed, 23 Jul 2003 09:33:40 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19fJk0-0002RE-C9 for emacs-devel@gnu.org; Wed, 23 Jul 2003 09:33:12 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19fJjn-0001va-Ak for emacs-devel@gnu.org; Wed, 23 Jul 2003 09:32:59 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19fJjT-00017B-R4 for emacs-devel@gnu.org; Wed, 23 Jul 2003 09:32:39 -0400 Original-Received: from rum.cs.yale.edu (localhost [127.0.0.1]) by rum.cs.yale.edu (8.12.8/8.12.8) with ESMTP id h6NDWd4Z030128; Wed, 23 Jul 2003 09:32:39 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.12.8/8.12.8/Submit) id h6NDWdRs030126; Wed, 23 Jul 2003 09:32:39 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Masatake YAMATO X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15684 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15684 > I've modified font lock related code in gdb-script-mode a bit. > Please, review my small patch. > > 2003-07-23 Masatake YAMATO > > * progmodes/gud.el (gdb-script-font-lock-keywords): > Put `font-lock-function-name-face' on a symbol which includes > `-' like `hook-run'. Put `font-lock-function-name-face' on > a symbol after `document'. Put font-lock-variable-name-face > on a symbol starting with $. > > > Index: lisp/progmodes/gud.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/progmodes/gud.el,v > retrieving revision 1.3 > diff -u -r1.3 gud.el > --- lisp/progmodes/gud.el 18 Jun 2003 23:26:28 -0000 1.3 > +++ lisp/progmodes/gud.el 23 Jul 2003 13:10:51 -0000 > @@ -2892,7 +2892,9 @@ > st)) > > (defvar gdb-script-font-lock-keywords > - '(("^define\\s-+\\(\\w+\\)" (1 font-lock-function-name-face)) > + '(("^define\\s-+\\(\\(\\w\\|-\\)+\\)" (1 font-lock-function-name-face)) Looks good (maybe we should use \\s_ instead of -, tho). > + ("^document\\s-+\\(\\(\\w\\|-\\)+\\)" (1 font-lock-function-name-face)) I must say I consciously did not do it, because I liked the fact that the function-name face was only put on the definition (I always put the documentation right next to it, so highlighting it a second time there is not helpful). > + ("$\\(\\w+\\)" (1 font-lock-variable-name-face)) Sounds good. Stefan