From: Paul Eggert <eggert@twinsun.com>
Cc: simon.marshall@misys.com, emacs-pretesters@gnu.org, emacs-devel@gnu.org
Subject: Re: Anyone built Emacs with gcc-3.3?
Date: Fri, 11 Jul 2003 15:52:41 -0700 (PDT) [thread overview]
Message-ID: <200307112252.h6BMqf009206@sic.twinsun.com> (raw)
In-Reply-To: <200307110955.h6B9tDY06306@sic.twinsun.com> (eggert@twinsun.com)
I found the other bug that was preventing Emacs 21.3 from building
with GCC 3.3 on Solaris 8 (sparc). Here is a patch. When I installed
this patch, together with the patch I sent earlier today, Emacs built
and installed on Solaris 8 with GCC 3.3, and ran OK on some simple
tests.
2003-07-11 Paul Eggert <eggert@twinsun.com>
* unexelf.c (unexec): Consider a section to precede the .bss
section if its addresses overlap that of .bss. This fixes the
bug reported by Simon Marshall in
<http://mail.gnu.org/archive/html/emacs-devel/2003-07/msg00033.html>,
if you also install the patch that I submitted yesterday in
<http://mail.gnu.org/archive/html/emacs-devel/2003-07/msg00207.html>.
This patch is related to my 1996-06-24 patch to unexelf.c
<http://www.geocrawler.com/archives/3/337/1996/6/0/1851704/>,
but it uses a more precise heuristic for deciding when the other
section precedes the .bss section.
--- emacs-21.3/src/unexelf.c 2002-10-15 07:21:44.000000000 -0700
+++ emacs-21.3-fix/src/unexelf.c 2003-07-11 14:59:48.649294000 -0700
@@ -971,8 +971,13 @@ unexec (new_name, old_name, data_start,
}
else
{
- /* Any section that was original placed AFTER the bss
- section should now be off by NEW_DATA2_SIZE. */
+ /* Any section that was originally placed after the .bss
+ section should now be off by NEW_DATA2_SIZE. If a
+ section overlaps the .bss section, consider it to be
+ placed after the .bss section. Overlap can occur if the
+ section just before .bss has less-strict alignment; this
+ was observed between .symtab and .bss on Solaris 2.5.1
+ (sparc) with GCC snapshot 960602. */
#ifdef SOLARIS_POWERPC
/* On PPC Reference Platform running Solaris 2.5.1
the plt section is also of type NOBI like the bss section.
@@ -986,9 +991,8 @@ unexec (new_name, old_name, data_start,
>= OLD_SECTION_H (old_bss_index-1).sh_offset)
NEW_SECTION_H (nn).sh_offset += new_data2_size;
#else
- if (round_up (NEW_SECTION_H (nn).sh_offset,
- OLD_SECTION_H (old_bss_index).sh_addralign)
- >= new_data2_offset)
+ if (NEW_SECTION_H (nn).sh_offset + NEW_SECTION_H (nn).sh_size
+ > new_data2_offset)
NEW_SECTION_H (nn).sh_offset += new_data2_size;
#endif
/* Any section that was originally placed after the section
next prev parent reply other threads:[~2003-07-11 22:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-04 8:33 Anyone built Emacs with gcc-3.3? Marshall, Simon
2003-07-04 8:41 ` Dhruva Krishnamurthy
2003-07-04 16:17 ` puneet
2003-07-08 22:41 ` Dave Love
2003-07-09 12:31 ` Puneet Goel
2003-07-15 22:31 ` Dave Love
2003-07-05 22:25 ` Richard Stallman
2003-07-11 9:55 ` Paul Eggert
2003-07-11 22:52 ` Paul Eggert [this message]
2003-07-13 14:56 ` Simon Leinen
2003-07-14 5:52 ` Paul Eggert
2003-07-12 5:32 ` Richard Stallman
2003-07-08 22:30 ` Dave Love
-- strict thread matches above, loose matches on Subject: below --
2003-07-04 12:36 Nelson H. F. Beebe
2003-07-07 8:26 Marshall, Simon
2003-07-08 14:28 ` Richard Stallman
2003-07-08 14:39 ` Jason Rumney
2003-07-09 5:34 ` Dhruva Krishnamurthy
2003-07-09 7:36 ` Pascal Obry
2003-07-09 7:59 ` Jason Rumney
2003-07-08 15:18 Marshall, Simon
2003-07-09 15:49 ` Richard Stallman
2003-07-11 9:57 ` Paul Eggert
2003-07-14 11:19 Marshall, Simon
[not found] ` <3F12B8E7.2C387FE7@yk.rim.or.jp>
2003-07-14 14:41 ` Eric Botcazou
2003-07-14 17:47 ` Paul Eggert
2003-07-14 19:40 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307112252.h6BMqf009206@sic.twinsun.com \
--to=eggert@twinsun.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-pretesters@gnu.org \
--cc=simon.marshall@misys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).