From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: Invisible colons in Emacs Info. Date: Sun, 06 Jul 2003 19:07:12 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200307062307.h66N7Cen013533@rum.cs.yale.edu> References: <200307062243.h66MhY609551@f7.net> <200307062258.h66MwJo07540@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1057532915 21424 80.91.224.249 (6 Jul 2003 23:08:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2003 23:08:35 +0000 (UTC) Cc: karl@freefriends.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jul 07 01:08:33 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19ZIcT-0005ZM-00 for ; Mon, 07 Jul 2003 01:08:33 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19ZIm3-0002fK-00 for ; Mon, 07 Jul 2003 01:18:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZIc0-0007Vn-OR for emacs-devel@quimby.gnus.org; Sun, 06 Jul 2003 19:08:04 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19ZIbO-0007BV-CH for emacs-devel@gnu.org; Sun, 06 Jul 2003 19:07:26 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19ZIbK-000773-So for emacs-devel@gnu.org; Sun, 06 Jul 2003 19:07:23 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZIbC-0006g7-Su for emacs-devel@gnu.org; Sun, 06 Jul 2003 19:07:14 -0400 Original-Received: from rum.cs.yale.edu (localhost [127.0.0.1]) by rum.cs.yale.edu (8.12.8/8.12.8) with ESMTP id h66N7DHl013535; Sun, 6 Jul 2003 19:07:13 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.12.8/8.12.8/Submit) id h66N7Cen013533; Sun, 6 Jul 2003 19:07:12 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Luc Teirlinck Original-cc: monnier+gnu/emacs@cs.yale.edu Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15439 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15439 > Karl Berry wrote: > > Mtools:(mtools). Mtools: > > a valid subtopic name? > > According to what we've discussed, that is invalid because the space > between the : and the ( is missing. I thought we had all agreed on this? > > You and me agreed, but I do not believe Stefan ever did. Otherwise > there would have been no reason for his recent changes. My recent change was done for the following reasons: 1 - centralize the definition of what is an acceptable menu entry name 2 - centralize the definition of what is an acceptable node name 3 - get rid of ad-hoc parsing code and use a more declarative style using regexps. 4 - accept some old menu entries (that are now considered invalid) as long as we can unambiguously recognize them. I'm fine with labelling menu entries that lack the space after the colon as invalid, but I see no reason not to tweak the regexp such that we can still recognize some of those old entries (as long as such tweaking does not impact valid cases). My change makes the code accept more cases than what we consider as "valid", but that seems like a feature rather than a bug since such entries exist and were valid until Emacs-21.3. Of course, the priority should be given to the correct treatment of valid entries. Stefan