From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: emacs-devel@gnu.org
Subject: Re: cua: quiet warning messages
Date: Mon, 16 Jun 2003 14:41:51 -0500 (CDT) [thread overview]
Message-ID: <200306161941.h5GJfp608799@eel.dms.auburn.edu> (raw)
In-Reply-To: <200306161912.h5GJCwM1020131@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)
Stefan Monnier wrote:
> Note that _any_ symbol other than `nil' or `-' should turn the mode
> _on_. 'toggle is a symbol, it is not `nil' and not `-'.
That's also how define-minor-mode behaves.
I defined a minor mode, vis-mode using define-minor-mode.
M-: (vis-mode 'toggle) _does_ toggle.
The 90% of the cases where a minor mode is called non-interactively with
a nil argument is when an unsuspecting user says
(add-hook 'foo-mode-hook 'bar-minor-mode)
The warning is thus there so that when it ends up turning the mode
OFF, it tells the user that it might not be doing what the
user expected. If the user (or author) really meant to turn the
mode off, she should pass a -1 argument to make it clear that
she knows what she's doing.
If foo-mode always turns bar-minor-mode on, then the above code seems
intentional and should not produce a warning. Note that, in your
example foo-mode-hook is probably a normal hook, so you can not just
pass an explicit argument, you have to define your own function,
disable-bar-minor-mode or whatever. The user may not know how to do
that and (add-hook 'foo-mode-hook 'bar-minor-mode) might actually be
stylistically inferior, but works. For inclusion in Emacs' source
code I _would_ define a disable-bar-minor-mode instead, because it
seems more robust, but why be that stylistically picky for a user's
.emacs. How does she turn the warning off if she gets tired of it?
If the current behavior would not be changed, then _at least_ it
should be _documented_ in _all_ places I mentioned.
Sincerely,
Luc.
next prev parent reply other threads:[~2003-06-16 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-16 17:04 cua: quiet warning messages Michael Mauger
2003-06-16 18:47 ` Luc Teirlinck
2003-06-16 19:12 ` Stefan Monnier
2003-06-16 19:41 ` Luc Teirlinck [this message]
2003-06-22 3:01 ` Richard Stallman
2003-06-23 17:00 ` Stefan Monnier
2003-07-01 15:17 ` Richard Stallman
2003-07-04 0:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306161941.h5GJfp608799@eel.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).