From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: Various simple.el patches Date: Tue, 27 May 2003 23:32:35 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200305280432.h4S4WZU17364@eel.dms.auburn.edu> References: <200305132031.h4DKVp58013718@rum.cs.yale.edu> <84llx9hhwp.fsf@lucy.is.informatik.uni-duisburg.de> <20030514124245.GA24487@gnu.org> <843cjhtytp.fsf@lucy.is.informatik.uni-duisburg.de> <20030514144839.GA6241@gnu.org> <844r3xr0ar.fsf@lucy.is.informatik.uni-duisburg.de> <84fznfzb9t.fsf@lucy.is.informatik.uni-duisburg.de> <84k7co464e.fsf@lucy.is.informatik.uni-duisburg.de> <200305210312.h4L3C4907897@eel.dms.auburn.edu> <200305220252.h4M2q9W10068@eel.dms.auburn.edu> <200305230352.h4N3qj211239@eel.dms.auburn.edu> <841xyqywtm.fsf@lucy.is.informatik.uni-duisburg.de> <847k8hiiwx.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1054096454 17985 80.91.224.249 (28 May 2003 04:34:14 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 28 May 2003 04:34:14 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed May 28 06:34:11 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19Ksde-0004fX-00 for ; Wed, 28 May 2003 06:34:10 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19Ksre-0001aA-00 for ; Wed, 28 May 2003 06:48:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19Ksdf-0003Bp-4a for emacs-devel@quimby.gnus.org; Wed, 28 May 2003 00:34:11 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19Ksc9-0002fV-SI for emacs-devel@gnu.org; Wed, 28 May 2003 00:32:37 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19Ksc7-0002cz-Dt for emacs-devel@gnu.org; Wed, 28 May 2003 00:32:36 -0400 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19Ksc6-0002aD-HR for emacs-devel@gnu.org; Wed, 28 May 2003 00:32:34 -0400 Original-Received: from eel.dms.auburn.edu (eel.dms.auburn.edu [131.204.53.108]) h4S4WVoc026430; Tue, 27 May 2003 23:32:31 -0500 (CDT) Original-Received: (from teirllm@localhost) by eel.dms.auburn.edu (8.11.6+Sun/8.11.6) id h4S4WZU17364; Tue, 27 May 2003 23:32:35 -0500 (CDT) X-Authentication-Warning: eel.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: kai.grossjohann@gmx.net In-reply-to: <847k8hiiwx.fsf@lucy.is.informatik.uni-duisburg.de> (kai.grossjohann@gmx.net) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14360 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14360 I saw the following entry in the Change Log: 003-05-23 Kai Grossjohann * simple.el (kill-region): If nothing was killed, and the previous command was not a kill, break kill sequence. (kill-whole-line): Don't use kill-line. Make it work with invisible lines. Make it repeatable. From Luc Teirlinck . But it apparently has not been committed (neither the kill-region part nor the kill-whole-line part.) I certainly see no problem with the kill-region part, assuming it is what you proposed in a message to this site. It seems to implement exactly what Richard decided, if I understood correctly. In as far as the kill-whole-line part is concerned, there is something confusing about the change log entry. Indeed, the main purpose of the change was to make kill-whole-line interact correctly with the kill-ring, both in read-write and read-only buffers. There were originally indeed problems with invisible text, but those turned out *not* to be bugs in the kill-whole-line code itself, but bugs in forward-visible-line, which I fixed. In the presence of invisibility properties that are lists of two or more elements, bugs in line-move-invisible remain, which still could affect kill-whole-line as well as other functions. If I understood correctly, it was decided that the best way to fix those problems was to make line-move-invisible a primitive and use existing C code in doing so. I do not know whether somebody is actively working on that, or planning to work on that, at present. Since 05-23, I made no changes in the actual code of kill-whole-line, but I added some comments and I propose to change the documentation string to: "Kill current line. With prefix arg, kill that many lines starting from the current line. If arg is negative, kill backward. Also kill the preceding newline. \(This is meant to make C-x z work well with negative arguments.\) If arg is zero, kill current line but exclude the trailing newline." Apart from that, I believe that the Change Log text needs to be changed for reasons outlined above. I plan no further changes. I did not have write access before, but I do now. What is the most convenient way to proceed from here: 1. You commit the original change (with maybe a changed Change Log) and then I commit the changes I made since. 2. I send you my latest changes and you commit everything in one piece. 3. You commit kill-region and I commit all revisions to kill-whole-line in one piece. Sincerely, Luc.