From: "Dhruva Krishnamurthy" <seagull@fastmail.fm>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Possible bug in resolving "~" folder
Date: Mon, 26 May 2003 10:49:06 +0530 [thread overview]
Message-ID: <20030526051906.F3F785F1F1@smtp.us2.messagingengine.com> (raw)
Hello,
I am using Emacs 21.3.50 (CVS) on W2K (MSVC 6.0 build).
Scenerio:
- Open a file (as in my case:"~/bin/cinclude.pl")
- Do a Save As (to "~/bin/cinclude1_0.pl")
- A call to (vc-mcvs-registered "~/bin/cinclude1_0.pl") is made
- In the "while" loop, a call to (file-name-directory "~") [progressively
going to top dir]
- The above call returns "nil". IMHO, it should have called
"expand-file-name" internally inside "file-name-directory" or should
handle 'nil' and return 'nil' instead of throwing error.
A fix which solved my problem was: in loaddefs.el @23991, call
expand-file-name
(defun vc-mcvs-registered (file)
(let ((dir file))
(while (and (stringp dir)
(not (equal dir (setq dir (file-name-directory (expand-file-name dir)))))) ;; Modified here
(setq dir (if (file-directory-p
(expand-file-name "MCVS/CVS" dir))
t (directory-file-name dir))))
(if (eq dir t)
(progn
(load "vc-mcvs")
(vc-mcvs-registered file)))))
--
Dhruva Krishnamurthy
Home: http://www32.brinkster.com/schemer/
next reply other threads:[~2003-05-26 5:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-26 5:19 Dhruva Krishnamurthy [this message]
2003-05-26 14:31 ` Possible bug in resolving "~" folder Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030526051906.F3F785F1F1@smtp.us2.messagingengine.com \
--to=seagull@fastmail.fm \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).