From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: bug in forward-visible-line: Patch Date: Fri, 23 May 2003 11:18:35 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200305231618.h4NGIZI11628@eel.dms.auburn.edu> References: <200305220443.h4M4h4w10124@eel.dms.auburn.edu> <200305221256.h4MCuhjv003998@rum.cs.yale.edu> <200305222140.h4MLe9r10843@eel.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1053707974 4052 80.91.224.249 (23 May 2003 16:39:34 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 23 May 2003 16:39:34 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 23 18:39:30 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19JFJu-00082s-00 for ; Fri, 23 May 2003 18:23:02 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19JFVj-00047F-00 for ; Fri, 23 May 2003 18:35:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JFHi-0007hK-GB for emacs-devel@quimby.gnus.org; Fri, 23 May 2003 12:20:46 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19JFGC-0007I0-7E for emacs-devel@gnu.org; Fri, 23 May 2003 12:19:12 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19JFGA-0007Gi-0Z for emacs-devel@gnu.org; Fri, 23 May 2003 12:19:10 -0400 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JFFZ-0006yk-Km; Fri, 23 May 2003 12:18:33 -0400 Original-Received: from eel.dms.auburn.edu (eel.dms.auburn.edu [131.204.53.108]) h4NGIWoc014847; Fri, 23 May 2003 11:18:32 -0500 (CDT) Original-Received: (from teirllm@localhost) by eel.dms.auburn.edu (8.11.6+Sun/8.11.6) id h4NGIZI11628; Fri, 23 May 2003 11:18:35 -0500 (CDT) X-Authentication-Warning: eel.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: miles@gnu.org In-reply-to: (message from Miles Bader on 23 May 2003 17:54:13 +0900) Original-cc: monnier+gnu/emacs@rum.cs.yale.edu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14139 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14139 Miles Bader wrote: BTW, one problem with the name `visiblep' is that it could be confused to mean the same thing as `pos-visible-in-window-p'. OTOH, I don't think I don't think `invisiblep' has this problem, since the term of `invisible' in emacs is strongly associated with the invisible property. As I already pointed out in my reply to David Kastrup, I failed to notice at the time when I proposed this function that there already was a function, `line-move-invisible', with essentially the same functionality as invisiblep. This function currently works fine in the absence of invisibility properties that are lists with two or more elements, but malfunctions in the presence of such invisibility properties. This is a bug that should be fixed and can easily be fixed by either using the new version of `line-move-invisible' which I proposed in a later posting or by using the C functionality and making `line-move-invisible' a primitive, as Stefan suggested. The advantage of the latter solution would be that if `line-move-invisible' used the same function as display to determine visibility (Stefan seems to suggest that this would be easy to implement), then it would actually be "theoretically impossible" for `line-move-invisible' to get it wrong. Sincerely, Luc.