From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: bug in forward-visible-line: Patch Date: Fri, 23 May 2003 10:50:33 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200305231550.h4NFoWb11612@eel.dms.auburn.edu> References: <200305220443.h4M4h4w10124@eel.dms.auburn.edu> <200305221256.h4MCuhjv003998@rum.cs.yale.edu> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1053708325 5933 80.91.224.249 (23 May 2003 16:45:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 23 May 2003 16:45:25 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 23 18:45:22 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19JFTC-0000OG-00 for ; Fri, 23 May 2003 18:32:38 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19JFf1-0004DC-00 for ; Fri, 23 May 2003 18:44:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JFQM-0001dD-8o for emacs-devel@quimby.gnus.org; Fri, 23 May 2003 12:29:42 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19JFQ1-0001ca-Ey for emacs-devel@gnu.org; Fri, 23 May 2003 12:29:21 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19JFQ0-0001cH-6y for emacs-devel@gnu.org; Fri, 23 May 2003 12:29:20 -0400 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JEoX-0000tK-Mp; Fri, 23 May 2003 11:50:37 -0400 Original-Received: from eel.dms.auburn.edu (eel.dms.auburn.edu [131.204.53.108]) h4NFoToc014817; Fri, 23 May 2003 10:50:30 -0500 (CDT) Original-Received: (from teirllm@localhost) by eel.dms.auburn.edu (8.11.6+Sun/8.11.6) id h4NFoWb11612; Fri, 23 May 2003 10:50:33 -0500 (CDT) X-Authentication-Warning: eel.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: dak@gnu.org In-reply-to: (David.Kastrup@t-online.de) Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14140 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14140 David Kastrup wrote: If (listp prop) evaluates to t, nil is always returned. Yes, this was a typo which I fixed in a later posting. It should have said: (dolist (var prop t) Also, the use of get-text-property was a bug. I should have used get-char-property or overlays would not be handled correctly. All of these are moot points now, since my main oversight at the time was not to notice that there already was a function with a similar functionality: line-move-invisible. (I noticed it later.) That function has problems that should be corrected as I pointed out, but I believe that doing so would eliminate the need for a new function. Sincerely, Luc.