unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: monnier+gnu/emacs@rum.cs.yale.edu
Subject: Re: bug in forward-visible-line: Patch
Date: Thu, 22 May 2003 17:51:53 -0400	[thread overview]
Message-ID: <200305222151.h4MLprRc014353@rum.cs.yale.edu> (raw)
In-Reply-To: 200305222140.h4MLe9r10843@eel.dms.auburn.edu

>    BTW, how about a `invisible-p' function that does above ?
> 
> I believe visiblep would be slightly more useful (does not make any
> real difference though).  I believe the usual convention is to only
> use -p if the function name is already multi-word, although this
> convention is not universally followed.
> 
> What about the following function?  I should still double-check it
> more carefully, but on first testing in a reasonably complex
> situation, it seems to work OK.  I believe that I could use the
> function not only to make forward-visible-line behave correctly (even
> after my patch, a problem remains, as I pointed out earlier), but
> probably in other situations as well.
> 
> ===File ~/invp.el===========================================
> (defun visiblep (&optional pos)
>   "Return t if character at POS is currently visible.
> POS defaults to point."
>   (unless pos (setq pos (point)))
>   (let ((prop (get-text-property pos 'invisible)))
>     (cond
>      ((null prop))
>      ((eq buffer-invisibility-spec t) nil)
>      ((memq prop buffer-invisibility-spec) nil)
>      ((assq prop buffer-invisibility-spec) nil)
>      ((listp prop)
>       (catch 'found
> 	(dolist (var prop)
> 	  (if (or (memq var buffer-invisibility-spec)
> 		  (assq var buffer-invisibility-spec))
> 	      (throw 'found nil)))))
>      (t))))

Don't reinvent the wheel: implement it in C where it's
already available (and so you're sure it really works the
same).  The C version return 0 1 or 2 so you can also tell
whether it's got an ellipsis or not.


	Stefan

  reply	other threads:[~2003-05-22 21:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-22  4:43 bug in forward-visible-line: Patch Luc Teirlinck
2003-05-22 12:56 ` Stefan Monnier
2003-05-22 17:46   ` Luc Teirlinck
2003-05-22 21:40   ` Luc Teirlinck
2003-05-22 21:51     ` Stefan Monnier [this message]
2003-05-22 22:03       ` Luc Teirlinck
2003-05-22 22:23         ` Luc Teirlinck
2003-05-22 23:38       ` Luc Teirlinck
2003-05-23  0:03         ` Luc Teirlinck
2003-05-22 22:27     ` David Kastrup
2003-05-23  8:54       ` Miles Bader
2003-05-23 16:18         ` Luc Teirlinck
2003-05-24 23:19           ` Richard Stallman
2003-05-23 22:48         ` Richard Stallman
2003-05-23 15:50       ` Luc Teirlinck
2003-05-22 21:46   ` Luc Teirlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200305222151.h4MLprRc014353@rum.cs.yale.edu \
    --to=monnier+gnu/emacs@rum.cs.yale.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).