Re: Incorporating patches into GNU Emacs

[Bill Wohler <wohler@newt.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]

Here's a specific example from bug.gnu.emacs: A patch from an Emacs user
who hasn't signed papers. Are you telling me that a) you'll ignore it,
or b) you'll really go through all the trouble of getting Gustav to sign
papers in order to use it?

p.s. Is there an Emacs Maintainers Manual where all this stuff is neatly
summarized?


From: Gustav Hållberg <gustav@virtutech.se>
Subject: vc-annotate does not copy truncate-lines from the origin buffer
If you have set truncate-lines in a buffer, it would make a lot of sense for
the vc-annotate command to use that setting in the newly created annotation
buffer too (the same could probably be said for other variables too, but this
is the one I was being annoyed by right now).

Suggested patch attached.

- Gustav

Newsgroups: gnu.emacs.bug
Date: 17 Apr 2003 11:34:18 +0200
X-Boundary: _______________________________________________________________________________

[2. text/x-patch; vc-annotate-truncate-lines.patch]

--- /disk1/sources/emacs-21.3/lisp/vc.el	Mon Jan 20 12:03:30 2003
+++ vc.el	Thu Apr 17 11:27:14 2003
@@ -2941,6 +2941,7 @@
   (vc-ensure-vc-buffer)
   (let* ((temp-buffer-name (concat "*Annotate " (buffer-name) "*"))
          (temp-buffer-show-function 'vc-annotate-display)
+	 (temp-truncate-lines truncate-lines)
          (rev (vc-workfile-version (buffer-file-name)))
          (vc-annotate-version 
           (if prefix (read-string 
@@ -2953,7 +2954,7 @@
                                    nil nil "1.0"))
             1.0))
          (vc-annotate-backend (vc-backend (buffer-file-name))))
-    (message "Annotating...")
+    (message "Annotating... %s" temp-truncate-lines)
     (if (not (vc-find-backend-function vc-annotate-backend 'annotate-command))
 	(error "Sorry, annotating is not implemented for %s"
 	       vc-annotate-backend))
@@ -2962,6 +2963,9 @@
 		       (file-name-nondirectory (buffer-file-name))
 		       (get-buffer temp-buffer-name)
                        vc-annotate-version))
+    (save-excursion
+      (set-buffer temp-buffer-name)
+      (setq truncate-lines temp-truncate-lines))
     ;; Don't use the temp-buffer-name until the buffer is created
     ;; (only after `with-output-to-temp-buffer'.)
     (setq vc-annotate-buffers

--
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.